[extension/encodingextension] Implement encoding extension #27092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ba5d87f to
0630d05
Compare
MovieStoreGuy
approved these changes
Sep 25, 2023
6b7265d to
5e8f5af
Compare
|
Going to wait until after the release to take care of conflicts, more reviews are appreciated. |
dmitryax
reviewed
Sep 25, 2023
dmitryax
reviewed
Sep 26, 2023
c277894 to
6c7fad5
Compare
dmitryax
reviewed
Sep 26, 2023
b35c0bf to
6cfa00a
Compare
6cfa00a to
1c85e37
Compare
dmitryax
reviewed
Sep 27, 2023
Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
|
@MovieStoreGuy please take another look, things have changed a lot since you approved the first time around. |
MovieStoreGuy
approved these changes
Sep 29, 2023
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…metry#27092) **Description:** Implement a first codec for the encoding extension. **Link to tracking Issue:** https://github.com/open-telemetry/opentelemetry-collector/issues/6272 **Testing:** Unit tests. **Documentation:** Some package docs. --------- Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Implement a first codec for the encoding extension.
Link to tracking Issue:
#28686
Testing:
Unit tests.
Documentation:
Some package docs.