-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
awsprometheusremotewrite: Add support for given IAM roles #2675
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2675 +/- ##
==========================================
+ Coverage 91.40% 91.43% +0.02%
==========================================
Files 435 435
Lines 21626 21630 +4
==========================================
+ Hits 19768 19778 +10
+ Misses 1391 1388 -3
+ Partials 467 464 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please be nice with codecov :)
Hi @bogdandrutu, I've tried ! |
* Add role_arn as a config option * Add tests for role_arn * update doc for role_arn * Fix tests * Add tests for roles scenarios * Modify AWS session authentication * Update role session identifier
Description:
Adding to the aws prometheus exporter the possibility to assume a role to unlock cross account scenarios
Link to tracking Issue: #2654
Testing:
Added some unit tests to cover the new parameter by running
make
Ran the collector using
make run
with a config to test the changesConfig
With metrics successfully being sent to the destination
Documentation:
Configuration option