-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/azuredataexplorer] Status Attributes added to exported traces #26682
Merged
jpkrohling
merged 13 commits into
open-telemetry:main
from
ag-ramachandran:bugfix/26496105-StatusMessage
Sep 20, 2023
Merged
[exporter/azuredataexplorer] Status Attributes added to exported traces #26682
jpkrohling
merged 13 commits into
open-telemetry:main
from
ag-ramachandran:bugfix/26496105-StatusMessage
Sep 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-ramachandran/opentelemetry-collector-contrib into bugfix/26496105-StatusMessage
ag-ramachandran
approved these changes
Sep 15, 2023
Hello @jpkrohling , will be great if you can have a look when you get time |
jpkrohling
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane, and code owners have approved.
Thanks a lot @jpkrohling. Would it be possible to merge this PR. |
CI is passing, PR merged. |
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…es (open-telemetry#26682) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Added an optional column in the exported trace data to store the status code and message as a dynamic field. **Link to tracking Issue:** <Issue number if applicable> [open-telemetry#26496](open-telemetry#26496) **Testing:** <Describe what testing was performed and which tests were added.> Performed E2E ingestion tests and added Test Cases for new fields. **Documentation:** <Describe the documentation added.> --------- Co-authored-by: Ramachandran A G <ramacg@microsoft.com> Co-authored-by: Ramachandran A G <106139410+ag-ramachandran@users.noreply.github.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added an optional column in the exported trace data to store the status code and message as a dynamic field.
Link to tracking Issue:
#26496
Testing:
Performed E2E ingestion tests and added Test Cases for new fields.
Documentation: