Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/azuredataexplorer] Status Attributes added to exported traces #26682

Merged

Conversation

asaharn
Copy link
Member

@asaharn asaharn commented Sep 14, 2023

Description:

Added an optional column in the exported trace data to store the status code and message as a dynamic field.

Link to tracking Issue:
#26496

Testing:
Performed E2E ingestion tests and added Test Cases for new fields.

Documentation:

@ag-ramachandran
Copy link
Contributor

Hello @jpkrohling , will be great if you can have a look when you get time

Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane, and code owners have approved.

@ag-ramachandran
Copy link
Contributor

Looks sane, and code owners have approved.

Thanks a lot @jpkrohling. Would it be possible to merge this PR.

@jpkrohling jpkrohling merged commit 5745f37 into open-telemetry:main Sep 20, 2023
@jpkrohling
Copy link
Member

CI is passing, PR merged.

@github-actions github-actions bot added this to the next release milestone Sep 20, 2023
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
…es (open-telemetry#26682)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
Added an optional column in the exported trace data to store the status
code and message as a dynamic field.


**Link to tracking Issue:** <Issue number if applicable>

[open-telemetry#26496](open-telemetry#26496)

**Testing:** <Describe what testing was performed and which tests were
added.>
Performed E2E ingestion tests and added Test Cases for new fields.

**Documentation:** <Describe the documentation added.>

---------

Co-authored-by: Ramachandran A G <ramacg@microsoft.com>
Co-authored-by: Ramachandran A G <106139410+ag-ramachandran@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants