-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] update core to v0.85.0 #26630
[chore] update core to v0.85.0 #26630
Conversation
Signed-off-by: Alex Boten <aboten@lightstep.com>
go.opentelemetry.io/collector/extension/auth v0.85.0 // indirect | ||
go.opentelemetry.io/collector/extension/ballastextension v0.85.0 // indirect | ||
go.opentelemetry.io/collector/extension/zpagesextension v0.85.0 // indirect | ||
go.opentelemetry.io/collector/featuregate v1.0.0-rcv0014 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this pulling back to the latest release instead of latest snapshot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understand what you mean by snapshot. This is preparing the release of contrib by updating all the deps to the latest released version in core
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The former version was go.opentelemetry.io/collector/featuregate v1.0.0-rcv0014.0.20230908201109-ab3d6c5b6470
(snapshot indicates September 8th) and now is back to go.opentelemetry.io/collector/featuregate v1.0.0-rcv0014
which was released last July. Maybe that doesn't matter, but it's happening for pdata as well, which has this change: open-telemetry/opentelemetry-collector@ebed8dd#diff-1f8826a44b89e0c16a541d21b89589fb86cdbbb6fcdccc976cc6a0e96d0834f7
Maybe that overall doesn't matter? Not sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v1.0.0-rcv0014 is the latest featuregate/pdata version. We got v1.0.0-rcv0014.0.20230908201109-ab3d6c5b6470 pointing to the latest commit in the core repo when make update-otel
runs without a module. So yes, technically, we are rolling back, but since there are no changes in featuregate or pdata, it's ok
For some reason,
make update-otel
failed for me. Will make a note to add an issue