Change rule expression to match endpoint types for receiver creator #2661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2661 +/- ##
==========================================
+ Coverage 91.57% 91.59% +0.02%
==========================================
Files 450 450
Lines 22192 22189 -3
==========================================
+ Hits 20323 20325 +2
+ Misses 1397 1394 -3
+ Partials 472 470 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
/cc @jrcamp |
|
@jrcamp please review. |
jrcamp
suggested changes
Mar 17, 2021
|
Please resolve merge conflict. |
Co-authored-by: Jay Camp <jay.r.camp@gmail.com>
jrcamp
approved these changes
Mar 23, 2021
Closed
pmatyjasek-sumo
referenced
this pull request
in pmatyjasek-sumo/opentelemetry-collector-contrib
Apr 28, 2021
…2661) Change the rule expression in receiver creator for matching endpoints types port, hostport and pod from type.port, type.hostport and type.pod respectively, to type == "port", type == "hostport" and type == "pod". Testing: Fixed unit tests failing due to change Documentation: Updated documentation to reflect change.
6 tasks
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
Allows Summary metrics to be exported to Prometheus. To walk through this feature, I created an adaptation of a Brian Brazil tutorial for DropWizard, to create a Java server at https://github.com/odeke-em/bugs/tree/master/opentelemetry-collector/2661 and it uses DropWizard, and exports out JVM statistics with Prometheus where the *gc_collection_seconds are of the summary kind when scraped by visiting http://localhost:1234/metrics which produced ``` # HELP jvm_gc_collection_seconds Time spent in a given JVM garbage collector in seconds. # TYPE jvm_gc_collection_seconds summary jvm_gc_collection_seconds_count{gc="G1 Young Generation",} 4.0 jvm_gc_collection_seconds_sum{gc="G1 Young Generation",} 0.026 jvm_gc_collection_seconds_count{gc="G1 Old Generation",} 0.0 ``` and then roundtripped the collector to scrape those metrics and then export them to Prometheus VS making Prometheus directly scrape that endpoint and then comparing results. Also added an end to end test to ensure that a mock DropWizard server which produces JVM statistics can be scraped by the Prometheus receiver, which will feed metrics to an active Prometheus exporter, and then we scrape from the Prometheus exporter to ensure that the summary metrics are written out and that they make sense. DropWizard -> Prometheus Receiver -> Prometheus Exporter -> HTTP scrape + Verify Fixes #2661
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Change the rule expression in receiver creator for matching endpoints types port, hostport and pod from type.port, type.hostport and type.pod respectively, to type == "port", type == "hostport" and type == "pod".
Testing: Fixed unit tests failing due to change
Documentation: Updated documentation to reflect change.