exporter/signalfx: Add translation rule to drop dimensions #2660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2660 +/- ##
=======================================
Coverage 91.41% 91.42%
=======================================
Files 435 435
Lines 21619 21655 +36
=======================================
+ Hits 19763 19798 +35
Misses 1390 1390
- Partials 466 467 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
0686a39 to
3463eb0
Compare
Add `drop_dimension` translation rule. Below are the various ways the
rule can be configured
```yaml
- action: drop_dimensions
metric_names:
k8s.pod.phase: true
without_dimension_pairs:
dim_key1:
dim_key2: [dim_val1, dim_val2]
- action: drop_dimensions
without_dimension_pairs:
dim_key1:
- action: drop_dimensions
metric_name: /^k8s\..*/
without_dimension_pairs:
dim_key: [dim_value]
```
Also, a `drop_dimension` rule has been added to the default list of translations.
The rule drops `opencensus.resourcetype` dimension from metrics generated by receivers written
using OC data structures. This rule can be removed once the `k8s_cluster` and `kubeletstats`
receivers have been refactored to use `pdata.Metrics`. Right now these dimensions are added as a
result of the conversion [here](https://github.com/open-telemetry/opentelemetry-collector/blob/v0.22.0/translator/internaldata/oc_to_resource.go#L128).
Dropping these dimensions will ensure MTSes aren't broken when the receivers are refactored
to use `pdata.Metrics` and this resource type dimension will cease to exist.
3463eb0 to
bf6b9cc
Compare
dmitryax
reviewed
Mar 12, 2021
607e235 to
a8583f7
Compare
pmatyjasek-sumo
referenced
this pull request
in pmatyjasek-sumo/opentelemetry-collector-contrib
Apr 28, 2021
* exporter/signalfx: Add translation rule to drop dimensions
Add `drop_dimension` translation rule. Below are the various ways the
rule can be configured
```yaml
- action: drop_dimensions
metric_names:
k8s.pod.phase: true
without_dimension_pairs:
dim_key1:
dim_key2: [dim_val1, dim_val2]
- action: drop_dimensions
without_dimension_pairs:
dim_key1:
- action: drop_dimensions
metric_name: /^k8s\..*/
without_dimension_pairs:
dim_key: [dim_value]
```
Also, a `drop_dimension` rule has been added to the default list of translations.
The rule drops `opencensus.resourcetype` dimension from metrics generated by receivers written
using OC data structures. This rule can be removed once the `k8s_cluster` and `kubeletstats`
receivers have been refactored to use `pdata.Metrics`. Right now these dimensions are added as a
result of the conversion [here](https://github.com/open-telemetry/opentelemetry-collector/blob/v0.22.0/translator/internaldata/oc_to_resource.go#L128).
Dropping these dimensions will ensure MTSes aren't broken when the receivers are refactored
to use `pdata.Metrics` and this resource type dimension will cease to exist.
* Address feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add
drop_dimensiontranslation rule. Below are the various ways therule can be configured
Also, a
drop_dimensionrule has been added to the default list of translations.The rule drops
opencensus.resourcetypedimension from metrics generated by receivers writtenusing OC data structures. This rule can be removed once the
k8s_clusterandkubeletstatsreceivers have been refactored to use
pdata.Metrics. Right now these dimensions are added as aresult of the conversion here.
Dropping these dimensions will ensure MTSes aren't broken when the receivers are refactored
to use
pdata.Metricsand this resource type dimension will cease to exist.Testing: Added tests
Documentation: Added inline comments.