Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade aliyun-log-go-sdk library #26510

Closed
wants to merge 1 commit into from
Closed

Upgrade aliyun-log-go-sdk library #26510

wants to merge 1 commit into from

Conversation

Mihai22125
Copy link

@Mihai22125 Mihai22125 commented Sep 7, 2023 •
edited by codeboten
Loading

Description:

Replace deprecated UpdateStsToken, AccessKeyID, and AccessKeySecret fields in ProducerConfig with CredentialsProvider and UpdateFuncProviderAdapter as per aliyun/aliyun-log-go-sdk#216.

Fixes #26456

@Mihai22125 Mihai22125 requested review from a team and TylerHelmuth September 7, 2023 16:10
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 7, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Mihai22125 / name: Mihai Țimbota-Belin (fe05d9c)

@github-actions github-actions bot added the exporter/alibabacloudlogservice Alibaba components label Sep 7, 2023
@songy23 songy23 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 7, 2023
songy23
songy23 reviewed Sep 7, 2023
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs make gotidy

codeboten
codeboten reviewed Sep 7, 2023
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @Mihai22125, pinging codeowners for a review @kongluoxing @qiansheng91 @shabicheng

@Mihai22125 Mihai22125 force-pushed the upgrade_library_aliyun branch 2 times, most recently from 36138be to 7d62401 Compare September 7, 2023 19:47
@github-actions github-actions bot added cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command labels Sep 7, 2023
@github-actions github-actions bot requested a review from pmcollins September 7, 2023 19:48
@Mihai22125 Mihai22125 force-pushed the upgrade_library_aliyun branch from 7d62401 to 1d9790f Compare September 7, 2023 20:01
@songy23 songy23 mentioned this pull request Sep 11, 2023
Closed
@songy23 songy23 mentioned this pull request Sep 18, 2023
Closed
@Mihai22125 Mihai22125 force-pushed the upgrade_library_aliyun branch from 1d9790f to fe05d9c Compare September 21, 2023 11:48
@codeboten
Copy link
Contributor

Pinging code owners @kongluoxing @qiansheng91 @shabicheng one more time. Please review this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 7, 2023
@github-actions
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Oct 22, 2023
@codeboten codeboten mentioned this pull request Nov 6, 2023
Closed
@codeboten codeboten mentioned this pull request Dec 8, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten left review comments

@songy23 songy23 songy23 approved these changes

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth

@kongluoxing kongluoxing Awaiting requested review from kongluoxing

@qiansheng91 qiansheng91 Awaiting requested review from qiansheng91

@shabicheng shabicheng Awaiting requested review from shabicheng

@mx-psi mx-psi Awaiting requested review from mx-psi

@dmitryax dmitryax Awaiting requested review from dmitryax

@pmcollins pmcollins Awaiting requested review from pmcollins

Assignees

@jpkrohling jpkrohling

Labels
cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command exporter/alibabacloudlogservice Alibaba components Skip Changelog PRs that do not require a CHANGELOG.md entry Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[exporter/alibabacloudlogservice] Upgrade github.com/aliyun/aliyun-log-go-sdk dependency
4 participants
@Mihai22125 @codeboten @songy23 @jpkrohling