-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
serialize each datapoint into separate line #2618
serialize each datapoint into separate line #2618
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2618 +/- ##
==========================================
+ Coverage 91.47% 91.48% +0.01%
==========================================
Files 439 439
Lines 21855 21858 +3
==========================================
+ Hits 19991 19996 +5
+ Misses 1394 1392 -2
Partials 470 470
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @sahejsingh!
@arminru @sahejsingh I cannot merge this until CLA is signed sorry. |
@bogdandrutu CLA signed 👍 |
@sahejsingh now the most important part, fix the build :)) Most likely run |
ah, I should have paid more attention. Will fix it now. |
ad559df
to
d521d5f
Compare
@bogdandrutu all checks have passed! |
* split each datapoint into separate point * fix unit tests * change data in unit tests
Description: Dynatrace API api expects each metric and its value to be on a separate line.
I might be wrong here, but to me it looks like the Dynatrace exporter incorrectly concatenates multiple data points for a single metric into one line. When this one line exceeds 2000 chars, the dynatrace server returns an error.
This change changes the way a DataPointSlice is serialized.
Now each data data point is serialised into its own line. The chunking later on can easily break this into 1000 lines (as required by the api).
versions:
otel library (used by client app): v0.17.0
otel-collector: 0.21.0
dynatrace: 1.211.111.20210222-093946
Link to tracking Issue: none.
Testing: unit testing and also able to push the metrics to a live instance of dynatrace server.
Documentation: none.