Use TraceData.Resource when Span.Resource not available. #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #254 +/- ##
=======================================
Coverage 77.84% 77.85%
=======================================
Files 126 126
Lines 6528 6530 +2
=======================================
+ Hits 5082 5084 +2
Misses 1166 1166
Partials 280 280
Continue to review full report at Codecov.
|
tigrannajaryan
approved these changes
May 21, 2020
wyTrivail
referenced
this pull request
in mxiamxia/opentelemetry-collector-contrib
Jul 13, 2020
…ble. (#254) Currently, TraceData.Resource is ignored in xray exporter. This means OTLP ingestion doesn't have resource information available because Span.Resource is never set. This change falls back to TraceData.Resource when needed.
mxiamxia
referenced
this pull request
in mxiamxia/opentelemetry-collector-contrib
Jul 22, 2020
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
golangci-lint runs its checks also on tests files, so make sure that they build properly before running the linter. there is no obvious solution to just build all the test without running them, so to work that around, we specify a -run flag with a value that surely isn't going to match any test function any time soon. that way we build all the tests, but no test is run. also, `go list ./...` returns only packages in the module, but no packages within submodule, so exporter/trace/jaeger (which is a submodule) was never on the list. so go test with those packages never ran the jaeger trace exporter tests. fix this by visiting every directory with the go.mod file and calling go test [options] ./... therein.
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
Current instrumentation uses the entire SQL query as the operation name which makes traces very hard to read and understand in addition to introducing high-cardinality issues. This commit fixes the problem by using only the SQL operation name and the DB name instead of the entire query.
jj22ee
added a commit
to jj22ee/opentelemetry-collector-contrib
that referenced
this pull request
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: <Describe what has changed.
Currently,
TraceData.Resourceis ignored in xray exporter. This means OTLP ingestion doesn't have resource information available becauseSpan.Resourceis never set. This change falls back toTraceData.Resourcewhen needed.Testing: Unit tests