[chore]Use Right file name for the prometheus compliance tests #24729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
crobert-1
requested changes
Aug 25, 2023
crobert-1
approved these changes
Aug 25, 2023
bryan-aguilar
approved these changes
Aug 25, 2023
rapphil
reviewed
Aug 29, 2023
| @@ -45,9 +45,10 @@ jobs: | |||
| with: | |||
| repository: prometheus/compliance | |||
| path: compliance | |||
There was a problem hiding this comment.
should we checkout a specific commit/tag?
There was a problem hiding this comment.
oh, I am not sure if we need to checkout specific tag. Since I see the tests are stable now at the main/recent commit.
Aneurysm9
approved these changes
Sep 1, 2023
This was referenced Sep 3, 2023
codeboten
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes the right file name for running the prometheus compliance tests.
The actual name of downloaded artifact as part of the test is
otelcol_0.42.0_linux_amd64. when we place the collector contrib artefact under the same name in the bin folder with the nameotelcol_linux_amd64the tests will still be run on otelcol_0.42.0_linux_amd64 artefact. so by changing the name of the artefact, the tests will run on top of that.Additional Context :
We shall need to track this issue prometheus/compliance#97 as the naming conventions of the artefacts used in the target could be changed upon the issue resolution
No ChangeLog entry is needed.