[AWS ECS container receiver]Add new metric for stopped container #2383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2383 +/- ##
=======================================
Coverage 90.95% 90.95%
=======================================
Files 411 411
Lines 20533 20546 +13
=======================================
+ Hits 18675 18687 +12
- Misses 1397 1398 +1
Partials 461 461
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
receiver/awsecscontainermetricsreceiver/awsecscontainermetrics/accumulator.go
Outdated
Show resolved
Hide resolved
receiver/awsecscontainermetricsreceiver/awsecscontainermetrics/accumulator.go
Outdated
Show resolved
Hide resolved
receiver/awsecscontainermetricsreceiver/awsecscontainermetrics/constant.go
Outdated
Show resolved
Hide resolved
JohnWu20
commented
Feb 23, 2021
receiver/awsecscontainermetricsreceiver/awsecscontainermetrics/accumulator.go
Outdated
Show resolved
Hide resolved
hossain-rayhan
approved these changes
Feb 25, 2021
|
Can we get this pr merged? |
anuraaga
reviewed
Mar 4, 2021
receiver/awsecscontainermetricsreceiver/awsecscontainermetrics/accumulator.go
Outdated
Show resolved
Hide resolved
anuraaga
approved these changes
Mar 4, 2021
bogdandrutu
approved these changes
Mar 5, 2021
|
@JohnWu20 this is a small hack, we probably should handle this differently in the future. Before merging I want to make sure that you are ok to change this in case we find a better solution to report this. |
|
Sure, I am OK to change this if we have better solutions in the future. |
|
This pr has got approved for a lot of days, can we get it merge now? @bogdandrutu |
kisieland
referenced
this pull request
in kisieland/opentelemetry-collector-contrib
Mar 16, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
pmatyjasek-sumo
referenced
this pull request
in pmatyjasek-sumo/opentelemetry-collector-contrib
Apr 28, 2021
* [AWS ECS container receiver]Add new metric for stopped container * [AWS ECS container receiver]Add new metric for stopped container * variable name chang * add more test cases * Add unit tests * re-run unit test * Solve the file conflict * Update the layout
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
…2383) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The processors and exporters will drop the data which only has the resource data but without metric data. However, for our ecs container receiver, we get only resource data when the container stopped. We need this data export to backend, so this pr will add a new metric called container.duration to calculate the container's running time for the stopped containers.
Testing:
Unit Test, and local test.