[WIP] Add support for loadbalancing with any resource attribute #18769
Conversation
This reverts commit d8e68e2.
…eid) and add logger support
…k to trace ID balancing
There was a problem hiding this comment.
I like the feature, but I think it could be done so that each routing key has its router. Trying to share code among them is likely to cause performance regressions, and I wouldn't be comfortable accepting this change as is without evidence that the performance is at least on par with the current implementation.
| @@ -54,7 +55,7 @@ func createDefaultConfig() component.Config { | |||
| } | |||
|
|
|||
| func createTracesExporter(_ context.Context, params exporter.CreateSettings, cfg component.Config) (exporter.Traces, error) { | |||
| return newTracesExporter(params, cfg) | |||
| return newTracesExporter(params, cfg, zap.NewNop()) | |||
There was a problem hiding this comment.
You can actually get a logger from params.
| @@ -73,6 +80,60 @@ func buildExporterConfig(cfg *Config, endpoint string) otlpexporter.Config { | |||
| return oCfg | |||
| } | |||
|
|
|||
| func SplitTracesByResourceAttr(batches ptrace.Traces, attrKeys []string) (map[string][]ptrace.Traces, error) { | |||
| // This code is based on the ConsumeTraces function of the batchperresourceattr | |||
There was a problem hiding this comment.
Shouldn't this be part of a common library then between the two components?
|
CLA check seems to be failing. Once this is fixed, I'll do another review. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Description:
This PR adds support for load balancing by any resource attribute (currently the
loadbalancingexporter only supports load balancing by trace ID or service name).Changes
consumeTraceis expected to receiveptrace.Tracewith a single Resource span (i.e. behavior before service name load balancing change)Sample Configuration
Trace ID Load Balancing Sequence Diagram
sequenceDiagram box trace_exporter.go participant ConsumeTraces participant consumeTracesById participant SplitTraces participant routeByTraceId participant consumeTrace end participant Trace Sink activate ConsumeTraces ConsumeTraces ->>+ consumeTracesById: function is chosen on exporter initialization consumeTracesById ->>+ SplitTraces: Sends a single ptrace.Traces SplitTraces ->>- consumeTracesById: Splits per RS/ILS/TraceID, returns a []ptrace.Traces loop For each Trace in []ptrace.Traces consumeTracesById ->>+ routeByTraceId: Extract the trace Id for the given batch routeByTraceId ->>- consumeTracesById: Returns the trace Id as a string consumeTracesById ->>+ consumeTrace: Send trace along with a routing key (trace Id) consumeTrace -)+ Trace Sink: Exports trace to endpoint based on key consumeTrace ->>- consumeTracesById: end consumeTracesById ->>- ConsumeTraces:Resource Attribute Load Balancing Sequence Diagram
sequenceDiagram box trace_exporter.go participant ConsumeTraces participant consumeTracesByResource participant consumeTracesById participant splitTracesByResourceAttr participant consumeTrace end participant Trace Sink activate ConsumeTraces ConsumeTraces ->>+ consumeTracesByResource: function is chosen on exporter initialization consumeTracesByResource ->>+ splitTracesByResourceAttr: Sends a single ptrace.Traces Note over consumeTracesByResource, splitTracesByResourceAttr: routingEntry:<br/>routingKey routingKey<br/>keyValue string<br/>trace ptrace.Traces splitTracesByResourceAttr ->>- consumeTracesByResource: Splits per RS/Resource Attribute, returns a []routingEntry loop For each in []routingEntry alt routingKey == resourceAttrRouting Note over consumeTracesByResource, consumeTrace: if any of the resource attributes were found in the trace<br/>we send directly to consumeTrace consumeTracesByResource ->>+ consumeTrace: Send trace along with a routing key (resource attribute value) else routingKey == traceIDRouting Note over consumeTracesByResource, consumeTrace: if NONE of the resource attributes were found <br/>we fall back to Trace ID balancing consumeTracesByResource ->>+ consumeTracesById: We pass the trace to be handled by Id balancing consumer consumeTracesById ->> consumeTrace: Follow the process in the Trace ID Balancing Diagram end consumeTrace -)+ Trace Sink: Exports trace to endpoint based on key consumeTrace ->>- consumeTracesByResource: end consumeTracesByResource ->>- ConsumeTraces:To-do
Link to tracking Issue: