Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sumologicexporter] Enable exporter #1859

Merged
merged 10 commits into from
Jan 7, 2021
Merged

[sumologicexporter] Enable exporter #1859

merged 10 commits into from
Jan 7, 2021

Conversation

sumo-drosiek
Copy link
Member

Description:

  • Enable sumologic exporter
  • Minor improvement for compress
  • Use github.com/pkg/errors for errors
  • Add context propagation to sender
  • Add support for dots in headers extrapolation

Link to tracking Issue:
#1498

Testing:

  • Unit tests
  • Manual e2e tests

Documentation:

  • Comments

@sumo-drosiek sumo-drosiek requested a review from a team December 17, 2020 12:53
@sumo-drosiek
Copy link
Member Author

Already after internal review
cc: @pmm-sumo @pmalek-sumo

@sumo-drosiek sumo-drosiek mentioned this pull request Dec 17, 2020
Closed
@codecov
Copy link

codecov bot commented Dec 17, 2020 •
edited
Loading

Codecov Report

Merging #1859 (7804f7a) into master (0d4da96) will increase coverage by 0.03%.
The diff coverage is 98.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1859      +/-   ##
==========================================
+ Coverage   90.25%   90.29%   +0.03%     
==========================================
  Files         386      386              
  Lines       19103    19161      +58     
==========================================
+ Hits        17242    17302      +60     
+ Misses       1399     1397       -2     
  Partials      462      462
Flag Coverage Δ
integration 69.77% <0.00%> (-0.12%) ⬇️
unit 89.06% <98.46%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
exporter/sumologicexporter/source_format.go 89.47% <ø> (ø)
exporter/sumologicexporter/exporter.go 81.91% <98.21%> (+31.91%) ⬆️
cmd/otelcontribcol/components.go 86.30% <100.00%> (+0.19%) ⬆️
exporter/sumologicexporter/compress.go 93.54% <100.00%> (+0.44%) ⬆️
exporter/sumologicexporter/sender.go 91.22% <100.00%> (-0.08%) ⬇️
receiver/k8sclusterreceiver/watcher.go 95.29% <0.00%> (-2.36%) ⬇️
exporter/sumologicexporter/filter.go 100.00% <0.00%> (+10.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d4da96...7804f7a. Read the comment docs.

pmalek-sumo
pmalek-sumo approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@pmalek-sumo pmalek-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@sumo-drosiek sumo-drosiek force-pushed the drosiek-sumologic-output-logs branch from 78e8487 to 7214046 Compare December 18, 2020 09:17
@jpkrohling jpkrohling removed their assignment Dec 28, 2020
@jpkrohling
Copy link
Member

I'm removing myself as assignee for this issue, as I'm unavailable until Jan 11.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2021

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 5, 2021
@bogdandrutu
Copy link
Member

Please rebase

@github-actions github-actions bot removed the Stale label Jan 7, 2021
Dominik Rosiek and others added 10 commits January 7, 2021 09:30
@pmalek-sumo
[sumologicexporter] Use sender in exporter
1ffe5cf 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Co-authored-by: Patryk Małek <69143962+pmalek-sumo@users.noreply.github.com>
[sumologicexporter] Enable Sumo Logic exporter
2f827d2 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
[sumologicexporter] Add pushLogsData tests
7b590a7 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
[sumologicexporter] Merge resource attributes for logs
208c2dc 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
[sumologicexporter] Explicitly propagate context
354b5a5 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
[sumologicexporter] Add tests for exporter init
9425492 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
[sumologicexporter] Add tests for pushLogsData
a3c4eef 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
[sumologicexporter] Fix compress and related test
9434138 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
[sumologicexporter] Add support for dots in headers extrapolation
5ad85cb 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
[sumologicexporter] Rename errors to errs in exporter
7804f7a 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
@sumo-drosiek sumo-drosiek force-pushed the drosiek-sumologic-output-logs branch from 7214046 to 7804f7a Compare January 7, 2021 08:30
@sumo-drosiek
Copy link
Member Author

@bogdandrutu rebased

@tigrannajaryan
Copy link
Member

All comments are resolved and the PR is approved. Merging.

@tigrannajaryan tigrannajaryan merged commit 6173b13 into open-telemetry:master Jan 7, 2021
dyladan referenced this pull request in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
@dmitryax
Correct indentation in zipkin exporter example (#1859)
8353bc9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmalek-sumo pmalek-sumo pmalek-sumo approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sumo-drosiek @jpkrohling @bogdandrutu @tigrannajaryan @pmalek-sumo