-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[internal/coreinternal/pdatautil] Write key prefix in MapHash function #17433
Merged
djaglowski
merged 1 commit into
open-telemetry:main
from
dmitryax:make-map-hash-resilient
Jan 9, 2023
Merged
[internal/coreinternal/pdatautil] Write key prefix in MapHash function #17433
djaglowski
merged 1 commit into
open-telemetry:main
from
dmitryax:make-map-hash-resilient
Jan 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foresight Summary
View More Details⭕ changelog workflow has finished in 3 seconds (9 minutes 25 seconds less than
|
Job | Failed Steps | Tests | |
---|---|---|---|
changelog | - 🔗 | N/A | See Details |
⭕ build-and-test-windows workflow has finished in 4 seconds (44 minutes 29 seconds less than main
branch avg.) and finished at 9th Jan, 2023.
Job | Failed Steps | Tests | |
---|---|---|---|
windows-unittest-matrix | - 🔗 | N/A | See Details |
windows-unittest | - 🔗 | N/A | See Details |
✅ check-links workflow has finished in 1 minute 4 seconds (1 minute 35 seconds less than main
branch avg.) and finished at 9th Jan, 2023.
Job | Failed Steps | Tests | |
---|---|---|---|
changed files | - 🔗 | N/A | See Details |
check-links | - 🔗 | N/A | See Details |
✅ tracegen workflow has finished in 1 minute 27 seconds (1 minute 36 seconds less than main
branch avg.) and finished at 9th Jan, 2023.
Job | Failed Steps | Tests | |
---|---|---|---|
build-dev | - 🔗 | N/A | See Details |
publish-stable | - 🔗 | N/A | See Details |
publish-latest | - 🔗 | N/A | See Details |
✅ prometheus-compliance-tests workflow has finished in 3 minutes 46 seconds (4 minutes 51 seconds less than main
branch avg.) and finished at 9th Jan, 2023.
Job | Failed Steps | Tests | |
---|---|---|---|
prometheus-compliance-tests | - 🔗 | ✅ 21 ❌ 0 ⏭ 0 🔗 | See Details |
build-and-test workflow has finished in 20 minutes 9 seconds (26 minutes 54 seconds less than main
branch avg.) and finished at 9th Jan, 2023.
Job | Failed Steps | Tests | |
---|---|---|---|
unittest-matrix (1.19, internal) | N/A | ✅ 618 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, internal) | N/A | ✅ 618 ❌ 0 ⏭ 0 🔗 | See Details |
correctness-metrics | N/A | ✅ 2 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, processor) | N/A | ✅ 1472 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, processor) | N/A | ✅ 1472 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, extension) | N/A | ✅ 528 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, extension) | N/A | ✅ 528 ❌ 0 ⏭ 0 🔗 | See Details |
correctness-traces | N/A | ✅ 17 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, receiver-0) | N/A | ✅ 2565 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, receiver-0) | N/A | ✅ 2565 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, exporter) | N/A | ✅ 2462 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, exporter) | N/A | ✅ 2462 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, other) | N/A | ✅ 4435 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, other) | N/A | ✅ 4435 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, receiver-1) | N/A | ✅ 1883 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, receiver-1) | N/A | ✅ 1883 ❌ 0 ⏭ 0 🔗 | See Details |
integration-tests | N/A | ✅ 55 ❌ 0 ⏭ 0 🔗 | See Details |
✅ load-tests workflow has finished in 7 minutes 58 seconds (7 minutes 45 seconds less than main
branch avg.) and finished at 9th Jan, 2023.
Job | Failed Steps | Tests | |
---|---|---|---|
loadtest (TestTraceAttributesProcessor) | - 🔗 | ✅ 3 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestIdleMode) | - 🔗 | ✅ 1 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestMetric10kDPS|TestMetricsFromFile) | - 🔗 | ✅ 6 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) | - 🔗 | ✅ 8 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) | - 🔗 | ✅ 12 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) | - 🔗 | ✅ 10 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestBallastMemory|TestLog10kDPS) | - 🔗 | ✅ 19 ❌ 0 ⏭ 0 🔗 | See Details |
setup-environment | - 🔗 | N/A | See Details |
*You can configure Foresight comments in your organization settings page.
dmitryax
force-pushed
the
make-map-hash-resilient
branch
from
January 7, 2023 03:02
41a70fe
to
87e9c9b
Compare
dmitryax
changed the title
[internal/coreinternal/pdatautil] Small improvements in MapHash function
[internal/coreinternal/pdatautil] Write key prefix in MapHash function
Jan 7, 2023
dmitryax
force-pushed
the
make-map-hash-resilient
branch
from
January 7, 2023 04:26
87e9c9b
to
189ca61
Compare
djaglowski
reviewed
Jan 9, 2023
Write a key prefix to avoid collisions with embedded maps and slices in some rare cases
dmitryax
force-pushed
the
make-map-hash-resilient
branch
from
January 9, 2023 19:43
189ca61
to
750d8ad
Compare
djaglowski
approved these changes
Jan 9, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write a key prefix to avoid collisions with embedded maps and slices in some rare cases
This is taken from #17169 but unrelated to the PR comments.