Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal/coreinternal/pdatautil] Write key prefix in MapHash function #17433

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Jan 7, 2023

Write a key prefix to avoid collisions with embedded maps and slices in some rare cases

This is taken from #17169 but unrelated to the PR comments.

@dmitryax dmitryax requested review from a team and codeboten January 7, 2023 02:41
@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 7, 2023
@runforesight
Copy link

runforesight bot commented Jan 7, 2023

Foresight Summary

    
Major Impacts

build-and-test-windows duration(4 seconds) has decreased 44 minutes 29 seconds compared to main branch avg(44 minutes 33 seconds).
View More Details

⭕  changelog workflow has finished in 3 seconds (9 minutes 25 seconds less than main branch avg.) and finished at 9th Jan, 2023.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

⭕  build-and-test-windows workflow has finished in 4 seconds (44 minutes 29 seconds less than main branch avg.) and finished at 9th Jan, 2023.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  check-links workflow has finished in 1 minute 4 seconds (1 minute 35 seconds less than main branch avg.) and finished at 9th Jan, 2023.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  tracegen workflow has finished in 1 minute 27 seconds (1 minute 36 seconds less than main branch avg.) and finished at 9th Jan, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 3 minutes 46 seconds (4 minutes 51 seconds less than main branch avg.) and finished at 9th Jan, 2023.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

 build-and-test workflow has finished in 20 minutes 9 seconds (26 minutes 54 seconds less than main branch avg.) and finished at 9th Jan, 2023.


Job Failed Steps Tests
unittest-matrix (1.19, internal) N/A  ✅ 618  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, internal) N/A  ✅ 618  ❌ 0  ⏭ 0    🔗 See Details
correctness-metrics N/A  ✅ 2  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, processor) N/A  ✅ 1472  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, processor) N/A  ✅ 1472  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, extension) N/A  ✅ 528  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, extension) N/A  ✅ 528  ❌ 0  ⏭ 0    🔗 See Details
correctness-traces N/A  ✅ 17  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-0) N/A  ✅ 2565  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-0) N/A  ✅ 2565  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, exporter) N/A  ✅ 2462  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, exporter) N/A  ✅ 2462  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, other) N/A  ✅ 4435  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, other) N/A  ✅ 4435  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-1) N/A  ✅ 1883  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-1) N/A  ✅ 1883  ❌ 0  ⏭ 0    🔗 See Details
integration-tests N/A  ✅ 55  ❌ 0  ⏭ 0    🔗 See Details

✅  load-tests workflow has finished in 7 minutes 58 seconds (7 minutes 45 seconds less than main branch avg.) and finished at 9th Jan, 2023.


Job Failed Steps Tests
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 19  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@dmitryax dmitryax force-pushed the make-map-hash-resilient branch from 41a70fe to 87e9c9b Compare January 7, 2023 03:02
@dmitryax dmitryax changed the title [internal/coreinternal/pdatautil] Small improvements in MapHash function [internal/coreinternal/pdatautil] Write key prefix in MapHash function Jan 7, 2023
@dmitryax dmitryax force-pushed the make-map-hash-resilient branch from 87e9c9b to 189ca61 Compare January 7, 2023 04:26
@dmitryax dmitryax requested a review from djaglowski as a code owner January 7, 2023 04:26
Write a key prefix to avoid collisions with embedded maps and slices in some rare cases
@dmitryax dmitryax force-pushed the make-map-hash-resilient branch from 189ca61 to 750d8ad Compare January 9, 2023 19:43
@djaglowski djaglowski merged commit e3d2bd5 into open-telemetry:main Jan 9, 2023
@dmitryax dmitryax deleted the make-map-hash-resilient branch January 10, 2023 11:42
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal/comparetest internal/core Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants