-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filereload receiver #15660
Add filereload receiver #15660
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs an issue and sponsor in accordance to the contributing guidelines for new components. Thanks!
Had filed issue. I can fix accordingly per the guidelines suggested if the idea looks good generally. Feel free to let me know if any question. |
This looks very interesting, however I think functionality like this may be more useful if broken down into 3 composable parts:
These bits can then be composed to result in the functionality that this PR suggests, but they can also be composed in other interesting ways. @open-telemetry/collector-approvers @open-telemetry/collector-contrib-approvers thoughts? |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Thanks for the comment, I will take a look at confmap and see how it can be leveraged in this receiver and get back soon. |
open-telemetry/opentelemetry-collector#5945 for watch implementation in
open-telemetry/opentelemetry-collector#6372 for connector implementation.
In fact the need is to spawn not only receivers but also processors, given usually different receivers(data source) require different processing logical, so maybe a mechanism to spawn receivers and processors(it will nice to be able to spawn exporter as well), it sounds like mechanism/ability to spawn pipelines dynamically will be needed. |
This is correct and one of the things we discussed in the past and wanted to do is to avoid restarting all components on config changes and only restart components that changed (plus components that are earlier in the pipeline since the chaining model requires it). This would be another great addition to the Collector. |
@newly12, as @tigrannajaryan pointed out, this is part of a bigger discussion. I encourage you to join the collector SIG calls if you haven't yet (I missed the last few ones myself). I'm closing this PR, but this should not discourage you from contributing features that will lead to the outcome you wanted when you proposed this. |
Description:
Add filereload receiver to support dynamically start/stop partial pipelines(receiver, processor) from configs.
Link to tracking Issue:
#15714
Testing:
UT.
Documentation:
Please check README doc.