-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[syslogreceiver] Add for RFC 6587 octet counting and non-transparent-framing #15358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpheps
force-pushed
the
syslog-add-rfc6587
branch
from
October 21, 2022 12:26
cb7bd28
to
f1cf9e1
Compare
cpheps
commented
Oct 21, 2022
djaglowski
reviewed
Oct 21, 2022
cpheps
force-pushed
the
syslog-add-rfc6587
branch
from
October 21, 2022 18:54
f1cf9e1
to
7e0b572
Compare
cpheps
force-pushed
the
syslog-add-rfc6587
branch
from
October 24, 2022 12:13
7e0b572
to
65e0e7a
Compare
@djaglowski I think this is read for another look. The CI failures look unrelated to my changes. |
djaglowski
reviewed
Oct 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple nits
…framing Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>
Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>
Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>
Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>
Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>
cpheps
force-pushed
the
syslog-add-rfc6587
branch
from
October 24, 2022 16:33
65e0e7a
to
7a41718
Compare
djaglowski
approved these changes
Oct 24, 2022
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
…framing (open-telemetry#15358) * Added support for syslog rfc 6587 octet counting and non-transparent-framing Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Added support for RFC 6587 octet counting and non-transparent-framing
Link to tracking Issue: Resolves #8390
Testing: Added new unit tests for each mode.
Documentation: Updated configuration documentation for syslogreceiver and corresponding stanza operators.