Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[syslogreceiver] Add for RFC 6587 octet counting and non-transparent-framing #15358

Merged
merged 5 commits into from
Oct 24, 2022

Conversation

cpheps
Copy link
Contributor

@cpheps cpheps commented Oct 20, 2022

Description: Added support for RFC 6587 octet counting and non-transparent-framing

Link to tracking Issue: Resolves #8390

Testing: Added new unit tests for each mode.

Documentation: Updated configuration documentation for syslogreceiver and corresponding stanza operators.

@cpheps cpheps force-pushed the syslog-add-rfc6587 branch from cb7bd28 to f1cf9e1 Compare October 21, 2022 12:26
@cpheps cpheps marked this pull request as ready for review October 21, 2022 13:10
@cpheps cpheps requested a review from a team October 21, 2022 13:10
@cpheps cpheps requested a review from djaglowski as a code owner October 21, 2022 13:10
pkg/stanza/docs/operators/syslog_parser.md Show resolved Hide resolved
pkg/stanza/operator/parser/syslog/syslog.go Outdated Show resolved Hide resolved
pkg/stanza/operator/parser/syslog/syslog.go Outdated Show resolved Hide resolved
pkg/stanza/operator/parser/syslog/syslog.go Outdated Show resolved Hide resolved
@cpheps
Copy link
Contributor Author

cpheps commented Oct 24, 2022

@djaglowski I think this is read for another look. The CI failures look unrelated to my changes.

Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple nits

pkg/stanza/operator/parser/syslog/syslog.go Outdated Show resolved Hide resolved
pkg/stanza/operator/parser/syslog/syslog.go Outdated Show resolved Hide resolved
pkg/stanza/operator/parser/syslog/syslog.go Outdated Show resolved Hide resolved
Corbin Phelps added 5 commits October 24, 2022 11:09
…framing

Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>
Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>
Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>
Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>
Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>
@cpheps cpheps force-pushed the syslog-add-rfc6587 branch from 65e0e7a to 7a41718 Compare October 24, 2022 16:33
@djaglowski djaglowski merged commit e6ac9b0 into open-telemetry:main Oct 24, 2022
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
…framing (open-telemetry#15358)

* Added support for syslog rfc 6587 octet counting and non-transparent-framing

Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[receivers/syslog] Support RFC6587 for message framing
3 participants