Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[CI] Reduce cache download timeout" #15243

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

djaglowski
Copy link
Member

Reverts #14689

I'm proposing to revert this in favor of managing the timeout at the workflow level. (Which was already in place.)

The reason the timeout was not taking effect was due to a documentation error, which I will correct in a followup PR if it is agreed that once-per-workflow is preferred.

@djaglowski djaglowski added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 18, 2022
@djaglowski djaglowski marked this pull request as ready for review October 18, 2022 13:05
@djaglowski djaglowski requested a review from a team October 18, 2022 13:05
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry I didn't notice existing ones

@dmitryax dmitryax merged commit 8ccaa27 into main Oct 18, 2022
@dmitryax dmitryax deleted the revert-14689-github-reduce-cache-download-timeout branch October 18, 2022 16:41
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
Revert "[CI] Reduce cache download timeout (open-telemetry#14689)"

This reverts commit 7429ab6.
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants