[pkg/ottl] Fix gocritic complaints #14623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
approved these changes
Sep 30, 2022
evan-bradley
approved these changes
Sep 30, 2022
| switch ctx.GetDataPoint().(type) { | ||
| case pmetric.NumberDataPoint: | ||
| return ctx.GetDataPoint().(pmetric.NumberDataPoint).DoubleValue() | ||
| numberDataPoint, ok := ctx.GetDataPoint().(pmetric.NumberDataPoint) |
There was a problem hiding this comment.
Suggested change
| numberDataPoint, ok := ctx.GetDataPoint().(pmetric.NumberDataPoint) | |
| if numberDataPoint, ok := ctx.GetDataPoint().(pmetric.NumberDataPoint); ok { |
I think keeping the assignment in the if statement would be a bit more succinct.
There was a problem hiding this comment.
Youre right. I should stop multitasking
There was a problem hiding this comment.
I do think it is more succinct but harder to read. It is much easier to follow the code without having to go to the "branches".
bogdandrutu
approved these changes
Sep 30, 2022
codeboten
approved these changes
Oct 3, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses gocritic complaints.
Related to #10466