[exporter/datadogexporter] Add logs support #13987

dineshg13 · 2022-09-08T15:53:35Z

Description: Add logs support for datadog exporter
Link to tracking Issue: [issue] (#2651)

Testing:

Documentation: Will add examples in the follow up PR

exporter/datadogexporter/README.md

exporter/datadogexporter/factory.go

exporter/datadogexporter/go.mod

exporter/datadogexporter/internal/logs/sender.go

exporter/datadogexporter/internal/testutils/test_utils.go

exporter/datadogexporter/logs_exporter_test.go

exporter/datadogexporter/internal/logs/translator.go

exporter/datadogexporter/README.md

exporter/datadogexporter/internal/logs/translator.go

exporter/datadogexporter/internal/logs/translator_test.go

exporter/datadogexporter/internal/logs/translator.go

exporter/datadogexporter/internal/logs/translator_test.go

exporter/datadogexporter/internal/testutils/test_utils.go

exporter/datadogexporter/internal/logs/translator.go

exporter/datadogexporter/internal/logs/translator_test.go

exporter/datadogexporter/internal/logs/translator.go

nhinsch · 2022-09-14T12:31:24Z

exporter/datadogexporter/internal/logs/translator.go

+		l.AdditionalProperties[otelSeverityNumber] = fmt.Sprintf("%d", lr.SeverityNumber())
+	} else if lr.SeverityText() != "" {
+		status = lr.SeverityText()
+		l.AdditionalProperties[otelSeverityText] = lr.SeverityText()


Right now, if there is a SeverityNumber present, we skip this code block and we don't add the SeverityText as an additional property. I think the additional properties should be added regardless; that is if the SeverityText and/or SeverityNumber are present, we should always preserve them as otelSeverityText and/or otelSeverityNumber. The if/else logic should only apply to what we use for the official status.

mx-psi

LGTM, no further comments from my side :)

Once Nick's comments are addressed this will be good to merge

exporter/datadogexporter/internal/logs/translator.go

exporter/datadogexporter/internal/logs/translator_test.go

nhinsch

Approved pending a few minor last comments.

exporter/datadogexporter/internal/logs/translator.go

gbbr

I have to review further, submitting what I have so far in case it helps.

exporter/datadogexporter/config.go

exporter/datadogexporter/factory.go

exporter/datadogexporter/factory_test.go

exporter/datadogexporter/internal/logs/sender.go

exporter/datadogexporter/internal/logs/translator.go

exporter/datadogexporter/factory.go

exporter/datadogexporter/factory_test.go

exporter/datadogexporter/logs_exporter.go

exporter/datadogexporter/factory.go

gbbr · 2022-09-26T19:05:10Z

exporter/datadogexporter/internal/logs/translator.go

+		l.Service = datadog.PtrString(serviceName)
+	}
+
+	// we need to set log attributes as AdditionalProperties


Why? Can you explain in the comment please?

exporter/datadogexporter/internal/logs/translator.go

exporter/datadogexporter/internal/testutils/log_test_utils.go

exporter/datadogexporter/factory.go

exporter/datadogexporter/factory_test.go

exporter/datadogexporter/internal/logs/sender.go

exporter/datadogexporter/internal/testutils/test_utils.go

exporter/datadogexporter/logs_exporter_test.go

gbbr · 2022-09-26T19:31:42Z

exporter/datadogexporter/logs_exporter_test.go

+// traceIDToUint64 converts 128bit traceId to 64 bit uint64
+func traceIDToUint64(b [16]byte) uint64 {


These should be shared but that's for another PR.

…dd-logs-support-datadog

gbbr

Please go through all the comments in the PR and make sure they are resolved. You've omitted some of them.

exporter/datadogexporter/config.go

exporter/datadogexporter/factory.go

gbbr · 2022-09-27T14:35:44Z

exporter/datadogexporter/internal/logs/doc.go

@@ -0,0 +1,18 @@
+// Copyright  The OpenTelemetry Authors


Suggested change

// Copyright The OpenTelemetry Authors

// Copyright The OpenTelemetry Authors

gbbr · 2022-09-27T14:35:50Z

exporter/datadogexporter/internal/logs/sender.go

@@ -0,0 +1,72 @@
+// Copyright  The OpenTelemetry Authors


Suggested change

// Copyright The OpenTelemetry Authors

// Copyright The OpenTelemetry Authors

gbbr · 2022-09-27T14:36:11Z

exporter/datadogexporter/internal/logs/sender.go

+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0


Suggested change

// http://www.apache.org/licenses/LICENSE-2.0

// http://www.apache.org/licenses/LICENSE-2.0

exporter/datadogexporter/internal/logs/translator.go

exporter/datadogexporter/logs_exporter.go

exporter/datadogexporter/config.go

exporter/datadogexporter/internal/testutils/logs.go

exporter/datadogexporter/internal/logs/translator.go

…dd-logs-support-datadog

fix gosum

9827d6c

dineshg13 changed the title ~~fix gosum~~ [exporter/datadogexporter] Add logs support Sep 8, 2022

dineshg13 added 2 commits September 8, 2022 13:33

fix lint issues + gotidy

319d550

fix lint issues + gotidy

f35b11a

dineshg13 marked this pull request as ready for review September 8, 2022 18:53

dineshg13 requested a review from a team September 8, 2022 18:53

dineshg13 requested a review from mx-psi as a code owner September 8, 2022 18:53

github-actions bot assigned bogdandrutu Sep 8, 2022

mx-psi previously requested changes Sep 9, 2022

View reviewed changes

dineshg13 force-pushed the dinesh.gurumurthy/add-logs-support-datadog branch from c2777d7 to 06721ee Compare September 10, 2022 16:51

PR Comments

188386d

dineshg13 force-pushed the dinesh.gurumurthy/add-logs-support-datadog branch from 06721ee to 188386d Compare September 12, 2022 01:38

nhinsch reviewed Sep 12, 2022

View reviewed changes

exporter/datadogexporter/README.md Outdated Show resolved Hide resolved

nhinsch reviewed Sep 12, 2022

View reviewed changes

exporter/datadogexporter/internal/logs/translator.go Outdated Show resolved Hide resolved

nhinsch reviewed Sep 12, 2022

View reviewed changes

exporter/datadogexporter/internal/logs/translator_test.go Show resolved Hide resolved

nhinsch reviewed Sep 12, 2022

View reviewed changes

exporter/datadogexporter/internal/logs/translator.go Outdated Show resolved Hide resolved

nhinsch reviewed Sep 12, 2022

View reviewed changes

exporter/datadogexporter/internal/logs/translator.go Outdated Show resolved Hide resolved

nhinsch reviewed Sep 12, 2022

View reviewed changes

exporter/datadogexporter/internal/logs/translator.go Outdated Show resolved Hide resolved

nhinsch reviewed Sep 12, 2022

View reviewed changes

exporter/datadogexporter/internal/logs/translator_test.go Show resolved Hide resolved

mx-psi reviewed Sep 12, 2022

View reviewed changes

exporter/datadogexporter/internal/testutils/test_utils.go Outdated Show resolved Hide resolved

nhinsch reviewed Sep 12, 2022

View reviewed changes

exporter/datadogexporter/internal/logs/translator.go Show resolved Hide resolved

nhinsch reviewed Sep 12, 2022

View reviewed changes

exporter/datadogexporter/internal/logs/translator.go Show resolved Hide resolved

mx-psi reviewed Sep 13, 2022

View reviewed changes

exporter/datadogexporter/internal/logs/translator.go Outdated Show resolved Hide resolved

dineshg13 added 3 commits September 13, 2022 20:26

PR comments - add more tests

583a265

merge upstream

c81b71f

update readme

4c263f8

nhinsch reviewed Sep 14, 2022

View reviewed changes

exporter/datadogexporter/internal/logs/translator_test.go Show resolved Hide resolved

nhinsch reviewed Sep 14, 2022

View reviewed changes

exporter/datadogexporter/internal/logs/translator_test.go Show resolved Hide resolved

nhinsch reviewed Sep 14, 2022

View reviewed changes

exporter/datadogexporter/internal/logs/translator.go Show resolved Hide resolved

nhinsch reviewed Sep 14, 2022

View reviewed changes

merge upstream + resolve conflicts

06146ed

mx-psi approved these changes Sep 19, 2022

View reviewed changes

nhinsch reviewed Sep 22, 2022

View reviewed changes

exporter/datadogexporter/internal/logs/translator.go Outdated Show resolved Hide resolved

nhinsch reviewed Sep 22, 2022

View reviewed changes

exporter/datadogexporter/internal/logs/translator_test.go Outdated Show resolved Hide resolved

nhinsch reviewed Sep 22, 2022

View reviewed changes

exporter/datadogexporter/internal/logs/translator_test.go Outdated Show resolved Hide resolved

nhinsch approved these changes Sep 22, 2022

View reviewed changes

merge upstream + resolve conflicts

b2320cd

gbbr reviewed Sep 23, 2022

View reviewed changes

exporter/datadogexporter/internal/logs/translator.go Outdated Show resolved Hide resolved

dineshg13 added 3 commits September 23, 2022 15:26

PR comments

de8ff07

merge upstream + resolve conflicts

6fa1b9f

remove duplicate test

16e7c3f

dineshg13 requested a review from gbbr September 25, 2022 20:36

revert un-needed comment change

172e02d

gbbr reviewed Sep 26, 2022

View reviewed changes

dineshg13 added 2 commits September 27, 2022 00:01

PR comments

5a4429e

Merge remote-tracking branch 'upstream/main' into dinesh.gurumurthy/a…

f246e2f

…dd-logs-support-datadog

dineshg13 force-pushed the dinesh.gurumurthy/add-logs-support-datadog branch from 1574385 to f246e2f Compare September 27, 2022 00:01

gbbr reviewed Sep 27, 2022

View reviewed changes

exporter/datadogexporter/internal/testutils/logs.go Outdated Show resolved Hide resolved

dineshg13 added 2 commits September 27, 2022 16:02

PR comments + remove send_log_record

5645641

modify tests

c8b974b

gbbr reviewed Sep 27, 2022

View reviewed changes

exporter/datadogexporter/internal/logs/translator.go Outdated Show resolved Hide resolved

dineshg13 added 2 commits September 27, 2022 20:21

Merge remote-tracking branch 'upstream/main' into dinesh.gurumurthy/a…

520fcb2

…dd-logs-support-datadog

fix lint issues

dce3249

gbbr approved these changes Sep 27, 2022

View reviewed changes

mx-psi added the ready to merge Code review completed; ready to merge by maintainers label Sep 27, 2022

mx-psi merged commit 009ad32 into open-telemetry:main Sep 27, 2022

dineshg13 mentioned this pull request Oct 19, 2022

REQUEST: New membership for @dineshg13 open-telemetry/community#1267

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[exporter/datadogexporter] Add logs support #13987

[exporter/datadogexporter] Add logs support #13987

dineshg13 commented Sep 8, 2022 •

edited

Loading

nhinsch Sep 14, 2022

mx-psi left a comment

nhinsch left a comment

gbbr left a comment

gbbr Sep 26, 2022

gbbr Sep 26, 2022

gbbr left a comment

gbbr Sep 27, 2022

gbbr Sep 27, 2022

gbbr Sep 27, 2022

		// traceIDToUint64 converts 128bit traceId to 64 bit uint64
		func traceIDToUint64(b [16]byte) uint64 {

	// Copyright The OpenTelemetry Authors
	// Copyright The OpenTelemetry Authors

	// http://www.apache.org/licenses/LICENSE-2.0
	// http://www.apache.org/licenses/LICENSE-2.0

[exporter/datadogexporter] Add logs support #13987

[exporter/datadogexporter] Add logs support #13987

Conversation

dineshg13 commented Sep 8, 2022 • edited Loading

nhinsch Sep 14, 2022

Choose a reason for hiding this comment

mx-psi left a comment

Choose a reason for hiding this comment

nhinsch left a comment

Choose a reason for hiding this comment

gbbr left a comment

Choose a reason for hiding this comment

gbbr Sep 26, 2022

Choose a reason for hiding this comment

gbbr Sep 26, 2022

Choose a reason for hiding this comment

gbbr left a comment

Choose a reason for hiding this comment

gbbr Sep 27, 2022

Choose a reason for hiding this comment

gbbr Sep 27, 2022

Choose a reason for hiding this comment

gbbr Sep 27, 2022

Choose a reason for hiding this comment

dineshg13 commented Sep 8, 2022 •

edited

Loading