Fix flaky test - increase file lifespan in rotation tests #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 27, 2020
|
I retriggered tests hoping to bypass #1380 but we are unfortunately still blocked on this. Otherwise should be good to go. |
|
@djaglowski please rebase, also remove the skip that I added |
Codecov Report
@@ Coverage Diff @@
## master #1384 +/- ##
=======================================
Coverage 89.88% 89.88%
=======================================
Files 326 326
Lines 16059 16059
=======================================
Hits 14434 14434
Misses 1181 1181
Partials 444 444
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
@bogdandrutu Thanks, should be all set now. |
tigrannajaryan
approved these changes
Oct 29, 2020
|
Thanks for the fix @djaglowski |
bogdandrutu
pushed a commit
that referenced
this pull request
Oct 29, 2020
)" This reverts commit 68d65d7.
tigrannajaryan
pushed a commit
that referenced
this pull request
Oct 29, 2020
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
- Removed the draft logsproto and now using the logs Protobufs from official OTLP repo. The rest of the changes are forced by this. - Added InstrumentationLibraryLogs and change the type of LogRecord.Body to AnyValue. - Updated fileexporter and logexporter to use the new log data type.
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
* Call otel.Handle with non-nil errors That's what normally happens in other call sites. Those two didn't check it, but passed the "error" to Handle. The default, delegating implementation of ErrorHandler was printing the error unconditionally, which resulted in pointless lines like `2020/12/07 19:51:28 <nil>` in demos, for example. * Add tests Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1382