Fix TestPeriodicMetrics test #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
bogdandrutu
approved these changes
Oct 23, 2020
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de
Description: Fixes the TestPeriodicMetrics test from the groupbytrace processor by ensuring that the views used during the test are clean.
Before this PR, the test would fail all the time when running multiple times in the same process:
After this PR, the test didn't fail after 100 attempts:
Link to tracking Issue: Closes open-telemetry/opentelemetry-collector#1927
Testing: n/a
Documentation: n/a