Upgrade to latest core, fix deprecate usages #13617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81a43a1 to
b6f0f94
Compare
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this pull request
Aug 25, 2022
See usages in open-telemetry/opentelemetry-collector-contrib#13617 where we had to check for the sample bit to set the value instead of just setting the entire value. Signed-off-by: Bogdan <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this pull request
Aug 25, 2022
See usages in open-telemetry/opentelemetry-collector-contrib#13617 where we had to check for the sample bit to set the value instead of just setting the entire value. Signed-off-by: Bogdan <bogdandrutu@gmail.com>
b6f0f94 to
8667def
Compare
|
Looks like the tests are still failing |
02f3c91 to
529bf23
Compare
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
529bf23 to
d8da3fa
Compare
|
Did we add a few dependancies in core that causes 20k+ in |
|
@dmitryax not that I know of, (jsoniter should have been there from traces, but not sure why now changed). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com