Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/loki] fix issue with log message quotation #12116

Merged
merged 5 commits into from
Jul 7, 2022

Conversation

harpratap
Copy link
Contributor

@harpratap harpratap commented Jul 6, 2022

Description: Wrap log message with double quotes

Link to tracking Issue: fixes #11827

Testing:
Added another check to see if the Entries.line contains attributed wrapped in double quotes

Documentation:

@harpratap harpratap requested a review from a team July 6, 2022 13:48
@harpratap harpratap requested a review from jpkrohling as a code owner July 6, 2022 13:48
@jpkrohling
Copy link
Member

Could you please add a changelog entry? It should be sufficient to create a file in "./unreleased".

@harpratap
Copy link
Contributor Author

@jpkrohling Ah sorry, I forgot to push it. Included it now!

@jpkrohling jpkrohling merged commit b1cd915 into open-telemetry:main Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loki Exporter - lokiexporter.convertLogBodyToEntry fails to quote value when there are whitespace characters
3 participants