Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stability level to components #12099

Merged
merged 8 commits into from
Jul 7, 2022

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented Jul 5, 2022

This updates all the receiver/processors/exporters to report their stability status, which is then logged when the collector service starts.

I didn't know if I should add a line to the changelog for every component, or just a single one for all components.

Alex Boten added 5 commits July 5, 2022 15:46
This updates all the receiver/exporters to report their stability status, which is then logged when the collector service starts.
@codeboten codeboten marked this pull request as ready for review July 6, 2022 04:12
@codeboten codeboten requested a review from a team July 6, 2022 04:12
@codeboten codeboten requested a review from a team July 6, 2022 04:12
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the components that concern me, and they look alright. The only one that left me scratching my head was the group by trace processor, which is in development, while all others are in beta. I'll change it to beta afterward, but if anyone knows the history behind this, do let me know. For now, I'll assume it was an oversight.

Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note. Otherwise, the components that I am familiar with look good.

@tigrannajaryan
Copy link
Member

Can we go with open-telemetry/opentelemetry-collector#5635 to avoid blocking the release for now?

@codeboten
Copy link
Contributor Author

Can we go with open-telemetry/opentelemetry-collector#5635 to avoid blocking the release for now?

@tigrannajaryan i think that's the right thing to do, otherwise it will be too rushed and doesn't give time to anyone with components outside of this repo to implement the same change

Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed my components and did a quick scan of other components and everything looked good. I'd say go with 1 changelog entry.

@codeboten codeboten merged commit fea0b65 into open-telemetry:main Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants