-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receivers/hostmetrics] add conntrack metrics #11769
Conversation
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
ccd0d36
to
f0b72b5
Compare
receiver/hostmetricsreceiver/internal/scraper/networkscraper/metadata.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Why do we want these metrics to be emitted by default? they seems like a good candidate for optional metrics |
What's the best way to determine when a metric should be on by default vs not? |
We don't have any strict guidelines to determine that, probably we should have it. Usually it's just up to code owner. I usually follow the following reasoning:
We also should take into consideration how stable a receiver is. If it has been used in production for some time, adding default metrics can affect downsteam backends that will unexpectedly receive additional load caused by added metrics with another collector upgrade. |
For linux only, adding metrics about connection tracking table. These are disabled by default.
2ccad0b
to
863052e
Compare
I agree, have disabled them by default. PTAL |
These thoughts would be awesome in the "Adding metrics to existing receivers" section of the contributing guide 👀 |
For linux only, adding metrics about connection tracking table.