Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/kubeletstats] Bring back k8s.container.name attribute #10848

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Jun 9, 2022

k8s.container.name attribute was recently unintentionally changed to container.name. This change brings k8s.container.name back

Fixes #10842

@dmitryax dmitryax requested review from a team and mx-psi June 9, 2022 03:06
`k8s.container.name` attribute was recently unintentionally changed to `container.name`. This change brings `k8s.container.name` back
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitryax dmitryax added the ready to merge Code review completed; ready to merge by maintainers label Jun 9, 2022
@codeboten codeboten merged commit b7375b3 into open-telemetry:main Jun 9, 2022
@dmitryax dmitryax deleted the fix-kubelet branch June 9, 2022 23:22
kentquirk pushed a commit to McSick/opentelemetry-collector-contrib that referenced this pull request Jun 14, 2022
…-telemetry#10848)

`k8s.container.name` attribute was recently unintentionally changed to `container.name`. This change brings `k8s.container.name` back
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[kubeletstatsreceiver] had a breaking resource label change on container metrics starting in v0.52.0
5 participants