Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit prometheus compatible histogram/summary to signalfx #10299

Merged
merged 2 commits into from
May 25, 2022

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented May 25, 2022

This PR:

  • fixes the buckets calculation for "upper_bound" (signalfx smart agent format).
  • Renames "upper_bound" to "le", change protected by a featuregate and can be reverted
  • Renames the metrics name emitted for the sum in Summary and Histogram to name + "_sum", change protected by a featuregate and can be reverted

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@bogdandrutu bogdandrutu requested a review from a team May 25, 2022 01:01
@bogdandrutu bogdandrutu requested a review from dmitryax as a code owner May 25, 2022 01:01
@bogdandrutu bogdandrutu changed the title Implement the logic to emit prometheus compatible histogram/summary to signalfx Emit prometheus compatible histogram/summary to signalfx May 25, 2022
This PR also fixes the buckets calculation for "upper_bound" (signalfx smart agent format).

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
CHANGELOG.md Show resolved Hide resolved
@bogdandrutu bogdandrutu merged commit 50e8ecb into open-telemetry:main May 25, 2022
kentquirk pushed a commit to McSick/opentelemetry-collector-contrib that referenced this pull request Jun 14, 2022
…try#10299)

This PR also fixes the buckets calculation for "upper_bound" (signalfx smart agent format).

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants