-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NewRelic exporter fails when no service name is provided #964
Labels
bug
Something isn't working
Comments
@MrAlias saw this on Gitter recently and filled a report to aid with fixing :) |
MrAlias
referenced
this issue
in MrAlias/opentelemetry-collector-contrib
Sep 8, 2020
Resolves #964 Validate the Node and ServiceInfo are not nil pointers before dereferencing them. Additionally, add tests to prevent regression of this bug.
bogdandrutu
pushed a commit
that referenced
this issue
Sep 8, 2020
Resolves #964 Validate the Node and ServiceInfo are not nil pointers before dereferencing them. Additionally, add tests to prevent regression of this bug.
dyladan
referenced
this issue
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
6 tasks
codeboten
pushed a commit
that referenced
this issue
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
User report on gitter indicated that NewRelic exporter fails. The quick investigation suggests this might happen when Service Name is not provided.
Steps to reproduce
Send a span with no service name
What did you expect to see?
No segfault
What did you see instead?
Segfault
What version did you use?
Windows, apparently v.0.9.0, though simple change in unit test reproduces this on any platform at master.
What config did you use?
Environment
OS: any OS
Additional context
It is not entirely clear if a default service name (as it happens for e.g. Zipkin exporter) or no service name needs to be exported in such scenario - maintainer input needed
The text was updated successfully, but these errors were encountered: