Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carbon Receiver panics after life cycle tests are completed #6978

Closed
MovieStoreGuy opened this issue Dec 30, 2021 · 3 comments
Closed

Carbon Receiver panics after life cycle tests are completed #6978

MovieStoreGuy opened this issue Dec 30, 2021 · 3 comments

Comments

@MovieStoreGuy
Copy link
Contributor

Describe the bug
From what I understand, the Carbon receiver being tested within #6974 doesn't not block on shutdown, meaning any error that uses host error reporter during the shutdown of the server will cause a panic outside the scope of the test.

Steps to reproduce
using #6974 and enabling the life cycle tests, then it should be visible.

What did you expect to see?
The Carbon receiver should block on shutdown until the server is shutdown.

What did you see instead?
The server is unbounded by the shutdown operation, so any failed errors will cause the test to fail
What version did you use?

Version: latest

What config did you use?
NA

Environment
NA

@MovieStoreGuy MovieStoreGuy added the bug Something isn't working label Dec 30, 2021
@jpkrohling
Copy link
Member

@pjanotti, you are listed as the code owner for this component. Would you be able to address this?

@jpkrohling jpkrohling changed the title Carbon Reciever panics after life cycle tests are completed Carbon Receiver panics after life cycle tests are completed Jan 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 9, 2022
animetauren pushed a commit to animetauren/opentelemetry-collector-contrib that referenced this issue Apr 4, 2023
Use git rev-parse instead.

Fixes open-telemetry#6977

Signed-off-by: Alex Boten <aboten@lightstep.com>
@github-actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants