-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/prometheus] static scape config doesn't work with Target Allocator #36062
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
closing as duplicate. Please add any useful additional information to the original bug. |
FYI I've opened the issue here, so I can reference it in change log. It is duplicate as in issue opened in Operator, but the issue seems to be on the Collector side ( Prometheus Receiver), see PR -> #36063 |
Ah, sorry. I missed that it was referencing an issue in another repo. |
…36063) #### Description Instead of clearing out prometheus scrape configuration I changed the code to copy the initial config every time we sync it from Target Allocator #### Link to tracking issue Fixes #36062 and open-telemetry/opentelemetry-operator#3034 <!--Describe what testing was performed and which tests were added.--> #### Testing tested in kind cluster with custom image <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> Co-authored-by: David Ashpole <dashpole@google.com>
…pen-telemetry#36063) #### Description Instead of clearing out prometheus scrape configuration I changed the code to copy the initial config every time we sync it from Target Allocator #### Link to tracking issue Fixes open-telemetry#36062 and open-telemetry/opentelemetry-operator#3034 <!--Describe what testing was performed and which tests were added.--> #### Testing tested in kind cluster with custom image <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> Co-authored-by: David Ashpole <dashpole@google.com>
…pen-telemetry#36063) #### Description Instead of clearing out prometheus scrape configuration I changed the code to copy the initial config every time we sync it from Target Allocator #### Link to tracking issue Fixes open-telemetry#36062 and open-telemetry/opentelemetry-operator#3034 <!--Describe what testing was performed and which tests were added.--> #### Testing tested in kind cluster with custom image <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> Co-authored-by: David Ashpole <dashpole@google.com>
Component(s)
receiver/prometheus
What happened?
Description
Duplicate of open-telemetry/opentelemetry-operator#3034
If you set both static scrape config and Target Allocator. Your static config will be ignored
Steps to Reproduce
Expected Result
Collector metrics to be scraped
Actual Result
No Collector metrics are scraped
Collector version
v0.112.0
Environment information
Environment
OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")
OpenTelemetry Collector configuration
Log output
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: