Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

goldendataset.GenerateMetric generates Histograms with invalid bucket counts #35594

Closed
tigrannajaryan opened this issue Oct 4, 2024 · 0 comments · Fixed by #35610
Closed

goldendataset.GenerateMetric generates Histograms with invalid bucket counts #35594

tigrannajaryan opened this issue Oct 4, 2024 · 0 comments · Fixed by #35610
Labels
bug Something isn't working

Comments

@tigrannajaryan
Copy link
Member

Component(s)

No response

What happened?

Description

goldendataset.GenerateMetric() to generates Histograms with invalid bucket counts. The number of bucket counts generates is equal to the number of bounds generated. This is wrong. The number of buckets must be equal to number of bounds plus one.

Steps to Reproduce

  1. Call goldendataset.GenerateMetric("testdata/generated_pict_pairs_metrics.txt")
  2. Examine Histogram datapoints in the returned data.

Expected Result

Correct Histograms as described in OTLP.

Actual Result

Incorrect Histograms are returned.

The Fix

The fix probably can be somewhere on this line, for example change it to:

counts := make([]uint64, len(bounds)+1)

Collector version

37cfec6

Environment information

No response

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response
@tigrannajaryan tigrannajaryan added bug Something isn't working needs triage New item requiring triage labels Oct 4, 2024
@narcis96 narcis96 mentioned this issue Oct 4, 2024
Merged
@songy23 songy23 removed the needs triage New item requiring triage label Oct 4, 2024
@github-actions github-actions bot mentioned this issue Oct 8, 2024
Closed
andrzej-stencel pushed a commit that referenced this issue Oct 9, 2024
@narcis96
goldendataset: fix histogram metric BucketCounts length (#35610)
a4fd3ae 
Correct Histograms as [described in
OTLP](https://github.com/open-telemetry/opentelemetry-proto/blob/main/opentelemetry/proto/metrics/v1/metrics.proto#L461)

Link to tracking Issue: Fixes
#35594

Testing: Tests passed
jmichalek132 pushed a commit to jmichalek132/opentelemetry-collector-contrib that referenced this issue Oct 10, 2024
@narcis96 @jmichalek132
goldendataset: fix histogram metric BucketCounts length (open-telemet…
6d32187 
…ry#35610)

Correct Histograms as [described in
OTLP](https://github.com/open-telemetry/opentelemetry-proto/blob/main/opentelemetry/proto/metrics/v1/metrics.proto#L461)

Link to tracking Issue: Fixes
open-telemetry#35594

Testing: Tests passed
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
@narcis96 @sbylica-splunk
goldendataset: fix histogram metric BucketCounts length (open-telemet…
b547efe 
…ry#35610)

Correct Histograms as [described in
OTLP](https://github.com/open-telemetry/opentelemetry-proto/blob/main/opentelemetry/proto/metrics/v1/metrics.proto#L461)

Link to tracking Issue: Fixes
open-telemetry#35594

Testing: Tests passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

goldendataset: fix histogram metric BucketCounts length narcis96/opentelemetry-collector-contrib
2 participants
@tigrannajaryan @songy23