[processor/transform] Failing unit test: Test_aggregateOnAttributes/matching_attribute

[crobert-1]

Component(s)

processor/transform

Describe the issue you're reporting

Failing CI/CD link

Failure output:

=== FAIL: internal/metrics Test_aggregateOnAttributes/matching_attribute (0.00s)
    func_aggregate_on_attributes_metrics_test.go:329: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/processor/transformprocessor/internal/metrics/func_aggregate_on_attributes_metrics_test.go:329
        	Error:      	Not equal: 
        	            	expected: pmetric.MetricSlice{orig:(*[]*v1.Metric)(0xc0004e8f30), state:(*internal.State)(0xc00050345c)}
        	            	actual  : pmetric.MetricSlice{orig:(*[]*v1.Metric)(0xc0004e8f18), state:(*internal.State)(0xc00050342c)}
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -9,2 +9,12 @@
        	            	      DataPoints: ([]*v1.NumberDataPoint) (len=2) {
        	            	+      (*v1.NumberDataPoint)({
        	            	+       Attributes: ([]v1.KeyValue) <nil>,
        	            	+       StartTimeUnixNano: (uint64) 0,
        	            	+       TimeUnixNano: (uint64) 0,
        	            	+       Value: (*v1.NumberDataPoint_AsDouble)({
        	            	+        AsDouble: (float64) 20
        	            	+       }),
        	            	+       Exemplars: ([]v1.Exemplar) <nil>,
        	            	+       Flags: (uint32) 0
        	            	+      }),
        	            	       (*v1.NumberDataPoint)({
        	            	@@ -27,12 +37,2 @@
        	            	        Flags: (uint32) 0
        	            	-      }),
        	            	-      (*v1.NumberDataPoint)({
        	            	-       Attributes: ([]v1.KeyValue) <nil>,
        	            	-       StartTimeUnixNano: (uint64) 0,
        	            	-       TimeUnixNano: (uint64) 0,
        	            	-       Value: (*v1.NumberDataPoint_AsDouble)({
        	            	-        AsDouble: (float64) 20
        	            	-       }),
        	            	-       Exemplars: ([]v1.Exemplar) <nil>,
make[2]: *** [../../Makefile.Common:131: test-with-cover] Error 1
make[1]: *** [Makefile:179: processor/transformprocessor] Error 2
make: *** [Makefile:131: gotest-with-cover] Error 2
        	            	-       Flags: (uint32) 0
        	            	       })
        	Test:       	Test_aggregateOnAttributes/matching_attribute

=== FAIL: internal/metrics Test_aggregateOnAttributes (0.01s)

=== FAIL: internal/metrics Test_aggregateOnAttributes/matching_attribute (re-run 1) (0.00s)
    func_aggregate_on_attributes_metrics_test.go:[329](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/10150354140/job/28067345409#step:9:330): 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/processor/transformprocessor/internal/metrics/func_aggregate_on_attributes_metrics_test.go:329
        	Error:      	Not equal: 
        	            	expected: pmetric.MetricSlice{orig:(*[]*v1.Metric)(0xc0000129f0), state:(*internal.State)(0xc00001543c)}
        	            	actual  : pmetric.MetricSlice{orig:(*[]*v1.Metric)(0xc0000129d8), state:(*internal.State)(0xc00001540c)}
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -9,2 +9,12 @@
        	            	      DataPoints: ([]*v1.NumberDataPoint) (len=2) {
        	            	+      (*v1.NumberDataPoint)({
        	            	+       Attributes: ([]v1.KeyValue) <nil>,
        	            	+       StartTimeUnixNano: (uint64) 0,
        	            	+       TimeUnixNano: (uint64) 0,
        	            	+       Value: (*v1.NumberDataPoint_AsDouble)({
        	            	+        AsDouble: (float64) 20
        	            	+       }),
        	            	+       Exemplars: ([]v1.Exemplar) <nil>,
        	            	+       Flags: (uint32) 0
        	            	+      }),
        	            	       (*v1.NumberDataPoint)({
        	            	@@ -27,12 +37,2 @@
        	            	        Flags: (uint32) 0
        	            	-      }),
        	            	-      (*v1.NumberDataPoint)({
        	            	-       Attributes: ([]v1.KeyValue) <nil>,
        	            	-       StartTimeUnixNano: (uint64) 0,
        	            	-       TimeUnixNano: (uint64) 0,
        	            	-       Value: (*v1.NumberDataPoint_AsDouble)({
        	            	-        AsDouble: (float64) 20
        	            	-       }),
        	            	-       Exemplars: ([]v1.Exemplar) <nil>,
        	            	-       Flags: (uint32) 0
        	            	       })
        	Test:       	Test_aggregateOnAttributes/matching_attribute

=== FAIL: internal/metrics Test_aggregateOnAttributes (re-run 1) (0.00s)

[github-actions]

Pinging code owners:

• processor/transform: @TylerHelmuth @kentquirk @bogdandrutu @evan-bradley

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[evan-bradley]

@odubajDT could you take a look?

[odubajDT]

@odubajDT could you take a look?

sure

[crobert-1]

+1 freq: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/10185859921/job/28176468068?pr=34278

This failure is techincally Test_aggregateOnAttributes/duplicate_attributes, but I believe it's likely related.

[pjanotti]

+1 Hitting this locally and also on CI https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/10188783585/job/28185598604#step:6:358

[crobert-1]

+1 freq: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/10207209845/job/28241588722?pr=34389

[songy23]

Saw a similar failure in Test_aggregateOnAttributes/duplicate_attributes
https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/10272482710/job/28424990328?pr=34433#step:5:280

[evan-bradley]

Thanks for the reports everyone. I just merged a change that should fix this. I'll keep an eye out, but please feel free to say something if you see another failure on a branch that has been based off this commit.

[odubajDT]

The issue seems to be resolved, this ticket may be closed

[crobert-1]

Thanks for the update @odubajDT, agreed that this can be closed. Resolved by #34338.