Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't run tests because of missing 'newAssertNoErrorHost' #31678

Closed
bouk opened this issue Mar 11, 2024 · 1 comment
Closed

Can't run tests because of missing 'newAssertNoErrorHost' #31678

bouk opened this issue Mar 11, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@bouk
Copy link
Contributor

bouk commented Mar 11, 2024

Component(s)

cmd/otelcontribcol

What happened?

Description

I'm unable to run the tests because newAssertNoErrorHost is missing

> # github.com/open-telemetry/opentelemetry-collector-contrib/cmd/otelcontribcol [github.com/open-telemetry/opentelemetry-collector-contrib/cmd/otelcontribcol.test]
> ./exporters_test.go:608:10: undefined: newAssertNoErrorHost
> ./receivers_test.go:504:10: undefined: newAssertNoErrorHost

Steps to Reproduce

go test ./...

Expected Result

The tests run

Actual Result

The tests fail to run

Collector version

6dcabb2ea3d31b833fddfc27e1fb827a0344a932

Environment information

No response

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response
@bouk bouk added bug Something isn't working needs triage New item requiring triage labels Mar 11, 2024
@andrzej-stencel
Copy link
Member

Looking at #30901 (comment) and #30884, the tests in cmd/otelcontribtests are not supposed to be run. They are being replaced and are not being run in CI.

@andrzej-stencel andrzej-stencel removed the needs triage New item requiring triage label Mar 11, 2024
bouk added a commit to bouk/nixpkgs that referenced this issue Mar 11, 2024
@bouk
opentelemetry-collector-contrib: disable check
08b58d7 
As discussed in
open-telemetry/opentelemetry-collector-contrib#31678,
the tests inside cmd/otelcontrib can't be run any more.
@bouk bouk mentioned this issue Mar 11, 2024
Merged
13 tasks
@github-actions github-actions bot mentioned this issue Mar 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bouk @andrzej-stencel