-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/podman] do not skip lifecycle checks #29994
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Pinging code owners for receiver/podman: @rogercoll. See Adding Labels via Comments if you do not have permissions to add labels yourself. |
@codeboten is this issue still open? |
@hamzmu yup, tests are still skipped:
|
can you assign this issue to me? |
Done! |
can I take this one? |
@codeboten @rogercoll any idea how to run the tests? This is one of my first prs and a similar issue suggested to ran the following: |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
WIP |
The current lifecycle of the podman's receiver (also the docker one) depends on the I think for the dockerstats receiver works because the socket is available on the CI. It fails on my local environment (docker disabled):
@codeboten Do you know how this issue is approach by other components? Should we change the scraper start logic? It seems to me, that enabling the socket on the CI is more an integration test. |
For the moment, I create PR to align the shutdown method with the dockestats receiver. |
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> - Adds the shutdown scraper method. The implementation cancels the `containerEventLoop` go routine. Similar to the dockerstats: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/dockerstatsreceiver/receiver.go#L76 - Moves the configuration validation to the start method, in alignment with the dockerstats receiver: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/dockerstatsreceiver/receiver.go#L55 **Link to tracking Issue:** Related issue #29994 **Testing:** <Describe what testing was performed and which tests were added.> Use scraper instead of metrics receiver interface. **Documentation:** <Describe the documentation added.> --------- Co-authored-by: Curtis Robert <crobert@splunk.com>
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been closed as inactive because it has been stale for 120 days with no activity. |
This test should not be skipped.
Originally posted by @codeboten in #29957 (comment)
The text was updated successfully, but these errors were encountered: