Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/datadog] 413 payload too large errors #2676

Closed
ericmustin opened this issue Mar 12, 2021 · 1 comment
Closed

[exporter/datadog] 413 payload too large errors #2676

ericmustin opened this issue Mar 12, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@ericmustin
Copy link
Contributor

Describe the bug

We've noticed that bc there is no truncation of span attributes (or datadog tags) at the collector-contrib datadogexporter, occasionally payloads get rejected for being excessively large. It would make sense to apply the same truncation logic/limits that occurs in the datadog-agent repository: https://github.com/DataDog/datadog-agent/blob/e081bed84866686eeab56a98da5ff9b4b9f03ded/pkg/trace/traceutil/truncate.go#L19-L26 to traces emitted by the opentelemtry-collector's datadogexporter.

Additional context

(Filing this for posterity and so others can chime in if they've noticed the behavior. We plan to address this issue and will link to PR when available. Please feel free to assign this issue to me 🙇 , cc @mx-psi )
@ericmustin ericmustin added the bug Something isn't working label Mar 12, 2021
@ericmustin ericmustin mentioned this issue Apr 20, 2021
Merged
tigrannajaryan pushed a commit that referenced this issue Apr 28, 2021
@ericmustin
[exporter/datadog]: add max tag length (#3185)
8443c7f 
This PR is part of work to address Payload size errors reported here: #2676

Combined with batching of spans/traces, spans with very large attribute values such as stacktraces can cause payload sizes to become excessive. This PR adds a max tag (a datadog span attribute, basically), value helper function, and truncates tag values when they're too  large, which brings this in line with Datadog-Agent limits: https://github.com/DataDog/datadog-agent/blob/140a4ee164261ef2245340c50371ba989fbeb038/pkg/trace/traceutil/truncate.go#L23

Additionally, worth noting that work being done to directly import and re-use portions of the datadog-agent codebase will make this sort of thing much easier, and work being done within datadog to permit shorter batching times should also help resolve the Payload size errors being seen. However for now this PR can help.

**Link to tracking Issue:** <Issue number if applicable> 

#2676
@ericmustin
Copy link
Contributor Author

ericmustin commented Sep 2, 2021 •
edited
Loading

There's been some work done to remediate this and open discussion is better done on the original issue, so closing this in favor of #1925

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ericmustin