Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/splunkhec] - Add a heartbeat check while exporter startup #24411

Closed
VihasMakwana opened this issue Jul 20, 2023 · 3 comments
Closed

[exporter/splunkhec] - Add a heartbeat check while exporter startup #24411

VihasMakwana opened this issue Jul 20, 2023 · 3 comments
Labels
enhancement New feature or request exporter/splunkhec

Comments

@VihasMakwana
Copy link
Contributor

VihasMakwana commented Jul 20, 2023 •
edited
Loading

Component(s)

exporter/splunkhec

Is your feature request related to a problem? Please describe.

If there's a faulty HEC token or if the index isn't selected for the given HEC token, then the exporter will start up without errors, and later on it will start failing with 4xx errors.
It makes sense to run a heartbeat check once with the configs before startup and return an error, if any.
We have a similar thing for health checks, but that doesn't take tokens or indexes into account.

Describe the solution you'd like

Add a configurable param and add a heartbeat check while startup, something similar to health_check_enabled.

Describe alternatives you've considered

No response

Additional context

No response
@VihasMakwana VihasMakwana added enhancement New feature or request needs triage New item requiring triage labels Jul 20, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@VihasMakwana VihasMakwana mentioned this issue Jul 21, 2023
Merged
mx-psi pushed a commit that referenced this issue Aug 1, 2023
@VihasMakwana @crobert-1
[exporter/splunkhec] - Add heartbeat check while startup (#24423)
a3556a4 
**Description:** Add heartbeat check while startup. This is different
than the `healtcheck_startup`, as the latter doesn't take token or index
into account.

**Link to tracking Issue:**
[<24411>](#24411)

**Testing:** Added relevant test cases

**Documentation:** <Describe the documentation added.>

---------

Co-authored-by: Curtis Robert <92119472+crobert-1@users.noreply.github.com>
@crobert-1
Copy link
Member

/label -needs-triage

@crobert-1
Copy link
Member

crobert-1 commented Aug 31, 2023 •
edited
Loading

@VihasMakwana Since your PR has been merged, can we close this issue?

@github-actions github-actions bot removed the needs triage New item requiring triage label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request exporter/splunkhec
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crobert-1 @VihasMakwana