-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmd/opampsupervisor] Add integration tests #24292
Comments
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
I'm working on this and hope to have a PR out soon. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
**Description:** Add tests that verify the Supervisor's behavior using a real Collector binary against an OpAMP server written with the opamp-go library. This tests a basic set of functionality mostly based on what is currently listed as implemented in the Supervisor's feature table. Right now these tests start the Supervisor using the Go API to avoid process handling, but could be changed to start it through a binary in the future. I've placed these tests in the E2E testing workflow even though they run fairly quickly since they depend on a built Collector binary, may become more expansive in the future, and don't fit in any of the existing jobs in the `build-and-test` workflow. I'm open to placing them in another location if we'd prefer them elsewhere. This also updates opamp-go to v0.9.0 to take advantage of open-telemetry/opamp-go#200. **Link to tracking Issue:** Resolves #24292
Component(s)
cmd/opampsupervisor
Is your feature request related to a problem? Please describe.
The OpAMP supervisor needs a high-level test suite that tests it correctly controls a Collector when communicating with an OpAMP server.
Describe the solution you'd like
Add an integration test suite that implements a testing instance of an OpAMP server to test the Supervisor, which will run a Collector binary.
Test the following:
The test framework and test cases can be iteratively developed over multiple PRs to make review easier.
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: