Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Managed Identity Auth for Azure Data Explorer #21924

Closed
ben-childs-docusign opened this issue May 15, 2023 · 8 comments
Closed

Support Managed Identity Auth for Azure Data Explorer #21924

ben-childs-docusign opened this issue May 15, 2023 · 8 comments

Comments

@ben-childs-docusign
Copy link
Contributor

Component(s)

exporter/azuredataexplorer

Is your feature request related to a problem? Please describe.

Currently the azure data explorer exporter requires an App ID + Secret in order to authenticate to ADX. For services running in Azure that can use Azure Managed Identity it would be more convenient to just configure an App ID and authenticate using managed identity.

Describe the solution you'd like

azuredataexplorer exporter should support specifying just Application ID rather than Application ID + Client ID + Tenant ID. When only the Application ID is specified it should pass this to azure-kusto-go client using "WithUserManagedIdentity".

it could also optionally support providing no credentials at all in which case it could use "UseDefaultAzureCredential"

Describe alternatives you've considered

No alternatives were considered. Using application + client secret auth requires us to manage additional secrets and rotate them, managed identity would allow us to authenticate without having to manage additional secrets.

Additional context

No response

@ben-childs-docusign ben-childs-docusign added enhancement New feature or request needs triage New item requiring triage labels May 15, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@ag-ramachandran
Copy link
Contributor

Hello @ben-childs-docusign, will pick this up for use with managed Identity as well. We're planning to have a couple of PR's, one for MI and the other for go-sdk update

@ben-childs-docusign
Copy link
Contributor Author

Hi @ag-ramachandran do you have any estimate for when you would be able to implement this?

@ag-ramachandran
Copy link
Contributor

Hello @ben-childs-docusign, Apologies for not picking this up yet. We're thinking of picking this up early next week. The fix should not be too hard itself, we can try a dev complete and submit for review next week!. Would that timeline work.

@andrzej-stencel andrzej-stencel removed the needs triage New item requiring triage label Jun 29, 2023
@ag-ramachandran
Copy link
Contributor

hello @ben-childs-docusign , Quick update : we should have the PR out by this Friday on this

mx-psi pushed a commit that referenced this issue Aug 2, 2023
**Description:**
Add support for ManagedIdentity. This enables passwordless config for
the ADX sink

**Link to tracking Issue:**  
#21924 

**Testing:** Manually tested

**Documentation:** Updated README documentation
@asaharn
Copy link
Member

asaharn commented Sep 1, 2023

Hi @ben-childs-docusign, the feature is completed. Can you close this issue please.

Copy link
Contributor

github-actions bot commented Nov 1, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 1, 2023
@mx-psi
Copy link
Member

mx-psi commented Nov 2, 2023

Closing based on #21924 (comment)

@mx-psi mx-psi closed this as completed Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants