Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flaky test: TestTimeoutWhenAggregationKeepHappen #20877

Closed
codeboten opened this issue Apr 12, 2023 · 12 comments · Fixed by #24244
Closed

flaky test: TestTimeoutWhenAggregationKeepHappen #20877

codeboten opened this issue Apr 12, 2023 · 12 comments · Fixed by #24244
Assignees
@djaglowski
Labels
flaky test a test is flaky pkg/stanza

Comments

@codeboten
Copy link
Contributor

Component(s)

pkg/stanza

Describe the issue you're reporting

https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/4676595428

ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/transformer/noop	0.023s
--- FAIL: TestTimeoutWhenAggregationKeepHappen (0.10s)
    recombine_test.go:507: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/operator/transformer/recombine/recombine_test.go:507
        	Error:      	Not equal: 
        	            	expected: "startnext"
        	            	actual  : "startnextnext"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-startnext
        	            	+startnextnext
        	Test:       	TestTimeoutWhenAggregationKeepHappen
FAIL
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/transformer/recombine	0.139s
@codeboten codeboten added the flaky test a test is flaky label Apr 12, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@djaglowski
Copy link
Member

@yutingcaicyt, do you mind taking a look at this? It appears to be related to #20742

@TylerHelmuth
Copy link
Member

Another occurrence here: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/4680950414/jobs/8292960563?pr=20754

@TylerHelmuth
Copy link
Member

Another: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/4680950414/jobs/8293618768?pr=20754

@TylerHelmuth TylerHelmuth mentioned this issue Apr 12, 2023
Merged
@swiatekm swiatekm mentioned this issue Apr 12, 2023
Merged
@yutingcaicyt
Copy link
Contributor

[pkg/stanza] Skip flaky test #20880

Sorry for making this mistake, I will fix it

@yutingcaicyt yutingcaicyt mentioned this issue Apr 13, 2023
Merged
djaglowski pushed a commit that referenced this issue Apr 13, 2023
@yutingcaicyt
fix the flaky test (#20877) (#20884)
21b356c
@djaglowski
Copy link
Member

Resolved by #20877

@codeboten
Copy link
Contributor Author

This appears to still be a problem:

--- FAIL: TestTimeoutWhenAggregationKeepHappen (0.22s)
    recombine_test.go:508: The entry should be flushed by now
--- FAIL: TestMaxAggregationTime (0.22s)
    recombine_test.go:553: The entry should be flushed by now

See https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/4690374412/jobs/8313377076

@codeboten codeboten reopened this Apr 13, 2023
@dmitryax
Copy link
Member

Another case https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/4745947060/jobs/8429056047?pr=20426

@djaglowski
Copy link
Member

@yutingcaicyt, do you mind taking another look at this one?

@yutingcaicyt
Copy link
Contributor

yutingcaicyt commented Apr 20, 2023 •
edited
Loading

@yutingcaicyt, do you mind taking another look at this one?
Yeah, I've created a pr #20899 @djaglowski

djaglowski pushed a commit that referenced this issue Apr 24, 2023
@yutingcaicyt
[pkg/stanza/operator/transformer/recombine] fix the flaky test(#20877) (
39681e6 
#20899)

Due to the use of goroutines, it's not suitable for some accurate tests for time.
@djaglowski
Copy link
Member

Unforutnately, this test failed here again: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/5177697361/jobs/9328121525#step:6:749

@djaglowski
Copy link
Member

Here again: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/5535880476/jobs/10102789011#step:6:348

@djaglowski djaglowski self-assigned this Jul 12, 2023
@djaglowski djaglowski mentioned this issue Jul 12, 2023
Merged
djaglowski added a commit that referenced this issue Jul 13, 2023
@djaglowski
[chore] Fix race condition in recombine operator test (#24244)
64ebbfd 
Fixes #20877
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djaglowski djaglowski

Labels
flaky test a test is flaky pkg/stanza
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore] Fix race condition in recombine operator test djaglowski/opentelemetry-collector-contrib
5 participants
@codeboten @djaglowski @dmitryax @TylerHelmuth @yutingcaicyt