[internal/aws/k8s/k8sclient]Enable gocritic (#12666)

Enable gocritic in internal/aws/k8s/k8sclient Signed-off-by: xin.li <xin.li@daocloud.io>
open-telemetry · Jul 25, 2022 · b773b88 · b773b88
1 parent 9af78b5
commit b773b88
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 10 deletions.
diff --git a/internal/aws/k8s/k8sclient/clientset.go b/internal/aws/k8s/k8sclient/clientset.go
@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// nolint:gocritic
 package k8sclient // import "github.com/open-telemetry/opentelemetry-collector-contrib/internal/aws/k8s/k8sclient"
 
 import (
@@ -134,7 +133,7 @@ func Get(logger *zap.Logger, options ...Option) *K8sClient {
 
 	mu.Lock()
 	if optionsToK8sClient[strOptions] == nil {
-		//construct the k8s client
+		// construct the k8s client
 		k8sClient := new(K8sClient)
 		err := k8sClient.init(logger, options...)
 		if err == nil {

diff --git a/internal/aws/k8s/k8sclient/endpoint.go b/internal/aws/k8s/k8sclient/endpoint.go
@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// nolint:gocritic
 package k8sclient // import "github.com/open-telemetry/opentelemetry-collector-contrib/internal/aws/k8s/k8sclient"
 
 import (
@@ -69,7 +68,7 @@ type epClient struct {
 
 	mu                      sync.RWMutex
 	podKeyToServiceNamesMap map[string][]string
-	serviceToPodNumMap      map[Service]int //only running pods will show behind endpoints
+	serviceToPodNumMap      map[Service]int // only running pods will show behind endpoints
 }
 
 func (c *epClient) PodKeyToServiceNames() map[string][]string {
@@ -96,7 +95,7 @@ func (c *epClient) refresh() {
 
 	objsList := c.store.List()
 
-	tmpMap := make(map[string]map[string]struct{}) //pod key to service names
+	tmpMap := make(map[string]map[string]struct{}) // pod key to service names
 	serviceToPodNumMapNew := make(map[Service]int)
 
 	for _, obj := range objsList {

diff --git a/internal/aws/k8s/k8sclient/endpoint_info.go b/internal/aws/k8s/k8sclient/endpoint_info.go
@@ -12,11 +12,10 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// nolint:gocritic
 package k8sclient // import "github.com/open-telemetry/opentelemetry-collector-contrib/internal/aws/k8s/k8sclient"
 
 type endpointInfo struct {
-	name       string //service name
-	namespace  string //namespace name
+	name       string // service name
+	namespace  string // namespace name
 	podKeyList []string
 }
diff --git a/internal/aws/k8s/k8sclient/helpers_test.go b/internal/aws/k8s/k8sclient/helpers_test.go
@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// nolint:gocritic
 package k8sclient
 
 import (
@@ -70,7 +69,7 @@ users:
 	if err := ioutil.WriteFile(tmpfile.Name(), []byte(content), 0600); err != nil {
 		t.Error(err)
 	}
-	//overwrite the default kube config path
+	// overwrite the default kube config path
 	kubeConfigPath = tmpfile.Name()
 	return kubeConfigPath
 }