Skip to content

Commit

Permalink
[extension/oidcauth] Fix case-sensitivity of authorization header (#1…
Browse files Browse the repository at this point in the history
  • Loading branch information
alexvanboxel authored Feb 21, 2023
1 parent b1c655b commit 9d0020e
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 1 deletion.
16 changes: 16 additions & 0 deletions .chloggen/oicdauth-fix-case-auth-header.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: bug_fix

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: oidcauthextension

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Fix case-sensitivity of authorization header

# One or more tracking issues related to the change
issues: [18405]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:
3 changes: 2 additions & 1 deletion extension/oidcauthextension/extension.go
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@ func (e *oidcExtension) start(context.Context, component.Host) error {

// authenticate checks whether the given context contains valid auth data. Successfully authenticated calls will always return a nil error and a context with the auth data.
func (e *oidcExtension) authenticate(ctx context.Context, headers map[string][]string) (context.Context, error) {
authHeaders := headers[e.cfg.Attribute]
metadata := client.NewMetadata(headers)
authHeaders := metadata.Get(e.cfg.Attribute)
if len(authHeaders) == 0 {
return ctx, errNotAuthenticated
}
Expand Down
7 changes: 7 additions & 0 deletions extension/oidcauthextension/extension_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,13 @@ func TestOIDCAuthenticationSucceeded(t *testing.T) {
assert.NoError(t, err)
assert.NotNil(t, ctx)

// test, upper-case header
ctx, err = p.Authenticate(context.Background(), map[string][]string{"Authorization": {fmt.Sprintf("Bearer %s", token)}})

// verify
assert.NoError(t, err)
assert.NotNil(t, ctx)

// TODO(jpkroehling): assert that the authentication routine set the subject/membership to the resource
}

Expand Down

0 comments on commit 9d0020e

Please sign in to comment.