[transformprocessor]: Remove unnecessary data copy when transform sum…

… to/from gauge

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

processor/transformprocessor/internal/metrics/func_convert_gauge_to_sum.go

@@ -54,8 +54,8 @@ func convertGaugeToSum(stringAggTemp string, monotonic bool) (ottl.ExprFunc[ottl
 		metric.SetEmptySum().SetAggregationTemporality(aggTemp)
 		metric.Sum().SetIsMonotonic(monotonic)
 
-		// Setting the data type removed all the data points, so we must copy them back to the metric.
-		dps.CopyTo(metric.Sum().DataPoints())
+		// Setting the data type removed all the data points, so we must move them back to the metric.
+		dps.MoveAndAppendTo(metric.Sum().DataPoints())
 
 		return nil, nil
 	}, nil

processor/transformprocessor/internal/metrics/func_convert_gauge_to_sum_datapoint.go

@@ -50,8 +50,8 @@ func convertDatapointGaugeToSum(stringAggTemp string, monotonic bool) (ottl.Expr
 		metric.SetEmptySum().SetAggregationTemporality(aggTemp)
 		metric.Sum().SetIsMonotonic(monotonic)
 
-		// Setting the data type removed all the data points, so we must copy them back to the metric.
-		dps.CopyTo(metric.Sum().DataPoints())
+		// Setting the data type removed all the data points, so we must move them back to the metric.
+		dps.MoveAndAppendTo(metric.Sum().DataPoints())
 
 		return nil, nil
 	}, nil

processor/transformprocessor/internal/metrics/func_convert_sum_to_gauge.go

@@ -30,7 +30,7 @@ func convertSumToGauge() (ottl.ExprFunc[ottlmetric.TransformContext], error) {
 		dps := metric.Sum().DataPoints()
 
 		// Setting the data type removed all the data points, so we must copy them back to the metric.
-		dps.CopyTo(metric.SetEmptyGauge().DataPoints())
+		dps.MoveAndAppendTo(metric.SetEmptyGauge().DataPoints())
 
 		return nil, nil
 	}, nil

processor/transformprocessor/internal/metrics/func_convert_sum_to_gauge_datapoint.go

@@ -29,8 +29,8 @@ func convertDatapointSumToGauge() (ottl.ExprFunc[ottldatapoint.TransformContext]
 
 		dps := metric.Sum().DataPoints()
 
-		// Setting the data type removed all the data points, so we must copy them back to the metric.
-		dps.CopyTo(metric.SetEmptyGauge().DataPoints())
+		// Setting the data type removed all the data points, so we must move them back to the metric.
+		dps.MoveAndAppendTo(metric.SetEmptyGauge().DataPoints())
 
 		return nil, nil
 	}, nil

processor/transformprocessor/internal/metrics/func_extract_sum_metric.go

@@ -32,7 +32,7 @@ func createExtractSumMetricFunction(_ ottl.FunctionContext, oArgs ottl.Arguments
 	return extractSumMetric(args.Monotonic)
 }
 
-// this interface helps unify the logic for extracting data from different histogram types
+// SumCountDataPoint interface helps unify the logic for extracting data from different histogram types
 // all supported metric types' datapoints implement it
 type SumCountDataPoint interface {
 	Attributes() pcommon.Map