[exporter/awskinesis] Restore Kinesis stream validation on the start (#…

…18522)

The exporter implements the exporter interfaces but it's not being used, `exporterhelper.NewLogsExporter` is applied instead. This change removes the implementation and moves the Start method to `NewLogsExporter` that is currently ignored

.chloggen/kinesis-exporter-fix-start.yaml

@@ -0,0 +1,11 @@
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: 'bug_fix'
+
+# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
+component: exporter/awskinesis
+
+# A brief description of the change.  Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: Restore Kinesis stream validation on the start
+
+# One or more tracking issues related to the change
+issues: [18522]

exporter/awskinesisexporter/exporter.go

@@ -24,8 +24,6 @@ import (
 	"github.com/aws/aws-sdk-go-v2/service/kinesis"
 	"github.com/aws/aws-sdk-go-v2/service/sts"
 	"go.opentelemetry.io/collector/component"
-	"go.opentelemetry.io/collector/consumer"
-	"go.opentelemetry.io/collector/exporter"
 	"go.opentelemetry.io/collector/pdata/plog"
 	"go.opentelemetry.io/collector/pdata/pmetric"
 	"go.opentelemetry.io/collector/pdata/ptrace"
@@ -48,12 +46,6 @@ type options struct {
 	NewKinesisClient func(conf aws.Config, opts ...func(*kinesis.Options)) *kinesis.Client
 }
 
-var (
-	_ exporter.Traces  = (*Exporter)(nil)
-	_ exporter.Metrics = (*Exporter)(nil)
-	_ exporter.Logs    = (*Exporter)(nil)
-)
-
 func createExporter(ctx context.Context, c component.Config, log *zap.Logger, opts ...func(opt *options)) (*Exporter, error) {
 	options := &options{
 		NewKinesisClient: kinesis.NewFromConfig,
@@ -134,42 +126,29 @@ func createExporter(ctx context.Context, c component.Config, log *zap.Logger, op
 	}, nil
 }
 
-// Start tells the exporter to start. The exporter may prepare for exporting
-// by connecting to the endpoint. Host parameter can be used for communicating
-// with the host after Start() has already returned. If error is returned by
-// Start() then the collector startup will be aborted.
-func (e Exporter) Start(ctx context.Context, _ component.Host) error {
+// start validates that the Kinesis stream is available.
+func (e Exporter) start(ctx context.Context, _ component.Host) error {
 	return e.producer.Ready(ctx)
 }
 
-// Capabilities implements the consumer interface.
-func (e Exporter) Capabilities() consumer.Capabilities {
-	return consumer.Capabilities{MutatesData: false}
-}
-
-// Shutdown is invoked during exporter shutdown.
-func (e Exporter) Shutdown(context.Context) error {
-	return nil
-}
-
 // ConsumeTraces receives a span batch and exports it to AWS Kinesis
-func (e Exporter) ConsumeTraces(ctx context.Context, td ptrace.Traces) error {
+func (e Exporter) consumeTraces(ctx context.Context, td ptrace.Traces) error {
 	bt, err := e.batcher.Traces(td)
 	if err != nil {
 		return err
 	}
 	return e.producer.Put(ctx, bt)
 }
 
-func (e Exporter) ConsumeMetrics(ctx context.Context, md pmetric.Metrics) error {
+func (e Exporter) consumeMetrics(ctx context.Context, md pmetric.Metrics) error {
 	bt, err := e.batcher.Metrics(md)
 	if err != nil {
 		return err
 	}
 	return e.producer.Put(ctx, bt)
 }
 
-func (e Exporter) ConsumeLogs(ctx context.Context, ld plog.Logs) error {
+func (e Exporter) consumeLogs(ctx context.Context, ld plog.Logs) error {
 	bt, err := e.batcher.Logs(ld)
 	if err != nil {
 		return err

exporter/awskinesisexporter/factory.go

@@ -72,7 +72,8 @@ func NewTracesExporter(ctx context.Context, params exporter.CreateSettings, conf
 		ctx,
 		params,
 		conf,
-		exp.ConsumeTraces,
+		exp.consumeTraces,
+		exporterhelper.WithStart(exp.start),
 		exporterhelper.WithTimeout(c.TimeoutSettings),
 		exporterhelper.WithRetry(c.RetrySettings),
 		exporterhelper.WithQueue(c.QueueSettings),
@@ -89,7 +90,8 @@ func NewMetricsExporter(ctx context.Context, params exporter.CreateSettings, con
 		ctx,
 		params,
 		c,
-		exp.ConsumeMetrics,
+		exp.consumeMetrics,
+		exporterhelper.WithStart(exp.start),
 		exporterhelper.WithTimeout(c.TimeoutSettings),
 		exporterhelper.WithRetry(c.RetrySettings),
 		exporterhelper.WithQueue(c.QueueSettings),
@@ -106,7 +108,8 @@ func NewLogsExporter(ctx context.Context, params exporter.CreateSettings, conf c
 		ctx,
 		params,
 		c,
-		exp.ConsumeLogs,
+		exp.consumeLogs,
+		exporterhelper.WithStart(exp.start),
 		exporterhelper.WithTimeout(c.TimeoutSettings),
 		exporterhelper.WithRetry(c.RetrySettings),
 		exporterhelper.WithQueue(c.QueueSettings),