-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[exporter/clickhouse] Update default logs table schema (2) (#34203)
**Description:** Previously updated in #33611, I am opening this to start a discussion on further improvements that can be made to the table. Notable changes: - Changed from monthly partitions to daily. With `ttl_only_drop_parts=1`, this will help drop data for TTLs shorter than 1 month (such as when your log retention is only 7 days). - Changed `idx_body` granularity to `8`, which should reduce the index size (especially beneficial for cloud services with separate storage) - Removed `TimestampDate` column - Simplified primary key to only use `TimestampTime`. Performance difference is negligible if not better. Also makes queries easier to write-- with the current version it requires that you provide both `TimestampDate` and `TimestampTime` for optimal sorting performance. - Separated and updated order by. Now it matches the primary key, with the addition of `Timestamp`, so that nanoseconds sorting is preserved by default. Let me know if you have any more suggestions. **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:**
- Loading branch information
1 parent
1035b3b
commit 44f6861
Showing
3 changed files
with
35 additions
and
8 deletions.
There are no files selected for viewing
27 changes: 27 additions & 0 deletions
27
.chloggen/clickhouseexporter_update_default_logs_table.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
# Use this changelog template to create an entry for release notes. | ||
|
||
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
change_type: enhancement | ||
|
||
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver) | ||
component: clickhouseexporter | ||
|
||
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
note: Updated the default logs table to a more optimized schema | ||
|
||
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
issues: [34203] | ||
|
||
# (Optional) One or more lines of additional information to render under the primary note. | ||
# These lines will be padded with 2 spaces and then inserted directly into the document. | ||
# Use pipe (|) for multiline entries. | ||
subtext: Improved partitioning and time range queries. | ||
|
||
# If your change doesn't affect end users or the exported elements of any package, | ||
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label. | ||
# Optional: The change log or logs in which this entry should be included. | ||
# e.g. '[user]' or '[user, api]' | ||
# Include 'user' if the change is relevant to end users. | ||
# Include 'api' if there is a change to a library API. | ||
# Default: '[user]' | ||
change_logs: [] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters