Skip to content

Commit

Permalink
[chore] Remove non-ucum units from prometheus readme (#26035)
Browse files Browse the repository at this point in the history
Follow-up to
#24647

Addresses comment in
#25887 (review)
  • Loading branch information
dashpole authored Aug 22, 2023
1 parent b13cc62 commit 302630b
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions pkg/translator/prometheus/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
| Percentages (unit is `1`) | Append `_ratio` (for gauges only) | `system.memory.utilization` with unit `1` → `system_memory_utilization_ratio` |
| Percentages (unit is `%`) | Replace `%` with `percent` `_percent` | `storage.filesystem.utilization` with unit `%` → `storage_filesystem_utilization_percent` |
| Rates (unit contains `/`) | Replace `/` with `per` | `astro.light.speed` with unit `m/s` → `astro_light_speed_meters_per_second` |
| Dollars (unit is `$`) | Replace `$` with `dollars` | `crypto.dogecoin.value` with unit `$` → `crypto_dogecoin_value_dollars` |
| Counter | Append `_total` | `system.processes.created` → `system_processes_created_total` |
List of standard OpenTelemetry units that will be translated to [Prometheus standard base units](https://prometheus.io/docs/practices/naming/#base-units):
Expand All @@ -54,11 +53,6 @@ List of standard OpenTelemetry units that will be translated to [Prometheus stan
| `MBy` | `megabytes` |
| `GBy` | `gigabytes` |
| `TBy` | `terabytes` |
| `B` | `bytes` |
| `KB` | `kilobytes` |
| `MB` | `megabytes` |
| `GB` | `gigabytes` |
| `TB` | `terabytes` |
| **SI Units** | |
| `m` | `meters` |
| `V` | `volts` |
Expand All @@ -70,7 +64,6 @@ List of standard OpenTelemetry units that will be translated to [Prometheus stan
| `Cel` | `celsius` |
| `Hz` | `hertz` |
| `%` | `percent` |
| `$` | `dollars` |
> **Note**
> Prometheus also recommends using base units (no kilobytes, or milliseconds, for example) but these functions will not attempt to convert non-base units to base units.
Expand Down

0 comments on commit 302630b

Please sign in to comment.