enable errcheck and exclude all components which are not passing. (#9726

)

* add errcheck to golangci-lint config, and exclude all components which are not passing.

Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>

* fix missing issues for linux

Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>

* fix missing issues for linux

Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>

.golangci.yml

@@ -94,8 +94,6 @@ linters-settings:
       - kilometres
 
 linters:
-  disable:
-    - errcheck
   enable:
     - exportloopref
     - gofmt
@@ -107,6 +105,7 @@ linters:
     - staticcheck
     - unconvert
     - unparam
+    - errcheck
 
 issues:
   # Excluding configuration per-path, per-linter, per-text and per-source

examples/demo/server/main.go

@@ -13,6 +13,7 @@
 // limitations under the License.
 
 // Sample contains a simple http server that exports to the OpenTelemetry agent.
+// nolint:errcheck
 package main
 
 import (

exporter/awscloudwatchlogsexporter/exporter.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package awscloudwatchlogsexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awscloudwatchlogsexporter"
 
 import (

exporter/awscloudwatchlogsexporter/exporter_test.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package awscloudwatchlogsexporter
 
 import (

exporter/awsemfexporter/emf_exporter.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package awsemfexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awsemfexporter"
 
 import (

exporter/awsemfexporter/grouped_metric_test.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package awsemfexporter
 
 import (

exporter/awsemfexporter/metric_declaration_test.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package awsemfexporter
 
 import (

exporter/awsemfexporter/metric_translator_test.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package awsemfexporter
 
 import (

exporter/awsxrayexporter/awsxray_test.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package awsxrayexporter
 
 import (

exporter/awsxrayexporter/internal/translator/cause.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package translator // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awsxrayexporter/internal/translator"
 
 import (

exporter/awsxrayexporter/internal/translator/writer_pool_test.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package translator
 
 import (

exporter/carbonexporter/exporter_test.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package carbonexporter
 
 import (

exporter/coralogixexporter/config_test.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package coralogixexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/coralogixexporter"
 
 import (

exporter/datadogexporter/factory_test.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package datadogexporter
 
 import (

exporter/datadogexporter/internal/metrics/consumer_test.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package metrics
 
 import (

exporter/datadogexporter/internal/model/translator/sketches_test.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package translator
 
 import (

exporter/datadogexporter/internal/testutils/test_utils.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package testutils // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/datadogexporter/internal/testutils"
 
 import (

exporter/datadogexporter/traces_exporter.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package datadogexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/datadogexporter"
 
 import (

exporter/datadogexporter/traces_exporter_test.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package datadogexporter
 
 import (

exporter/dynatraceexporter/metrics_exporter_test.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package dynatraceexporter
 
 import (

exporter/elasticexporter/exporter_test.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package elasticexporter
 
 import (

exporter/elasticexporter/internal/translator/elastic/metadata.go

@@ -13,6 +13,7 @@
 // limitations under the License.
 
 // Package elastic contains an OTLP exporter for Elastic APM.
+// nolint:errcheck
 package elastic // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/elasticexporter/internal/translator/elastic"
 
 import (

exporter/elasticsearchexporter/exporter.go

@@ -14,6 +14,7 @@
 
 // Package elasticsearchexporter contains an opentelemetry-collector exporter
 // for Elasticsearch.
+// nolint:errcheck
 package elasticsearchexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/elasticsearchexporter"
 
 import (

exporter/elasticsearchexporter/exporter_test.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package elasticsearchexporter
 
 import (

exporter/elasticsearchexporter/internal/objmodel/objmodel.go

@@ -40,6 +40,7 @@
 // Ingest Node is used. But either way, we try to present only well formed
 // document to Elasticsearch.
 
+// nolint:errcheck
 package objmodel // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/elasticsearchexporter/internal/objmodel"
 
 import (

exporter/googlecloudexporter/legacymetrics.go

@@ -14,6 +14,7 @@
 
 // Package googlecloudexporter contains the wrapper for OpenTelemetry-GoogleCloud
 // exporter to be used in opentelemetry-collector.
+// nolint:errcheck
 package googlecloudexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/googlecloudexporter"
 
 import (

exporter/googlecloudexporter/legacymetrics_test.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package googlecloudexporter
 
 import (

exporter/honeycombexporter/honeycomb.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package honeycombexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/honeycombexporter"
 
 import (

exporter/honeycombexporter/honeycomb_test.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package honeycombexporter
 
 import (

exporter/humioexporter/humio_client.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package humioexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/humioexporter"
 
 import (

exporter/jaegerthrifthttpexporter/exporter.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package jaegerthrifthttpexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/jaegerthrifthttpexporter"
 
 import (

exporter/loadbalancingexporter/factory.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package loadbalancingexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/loadbalancingexporter"
 
 import (

exporter/loadbalancingexporter/loadbalancer.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package loadbalancingexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/loadbalancingexporter"
 
 import (

exporter/loadbalancingexporter/loadbalancer_test.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package loadbalancingexporter
 
 import (

exporter/loadbalancingexporter/log_exporter_test.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package loadbalancingexporter
 
 import (

exporter/loadbalancingexporter/resolver_dns_test.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package loadbalancingexporter
 
 import (

exporter/loadbalancingexporter/resolver_static.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package loadbalancingexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/loadbalancingexporter"
 
 import (

exporter/loadbalancingexporter/resolver_static_test.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package loadbalancingexporter
 
 import (

exporter/loadbalancingexporter/trace_exporter_test.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package loadbalancingexporter
 
 import (

exporter/newrelicexporter/factory.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package newrelicexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/newrelicexporter"
 
 import (

exporter/newrelicexporter/newrelic.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package newrelicexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/newrelicexporter"
 
 import (

exporter/prometheusexporter/prometheus_test.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package prometheusexporter
 
 import (

exporter/prometheusremotewriteexporter/wal_test.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package prometheusremotewriteexporter
 
 import (

exporter/sentryexporter/sentry_exporter_test.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package sentryexporter
 
 import (

exporter/signalfxexporter/dpclient.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package signalfxexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/signalfxexporter"
 
 import (

exporter/signalfxexporter/eventclient.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package signalfxexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/signalfxexporter"
 
 import (

exporter/signalfxexporter/exporter_test.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package signalfxexporter
 
 import (

exporter/signalfxexporter/factory_test.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// nolint:errcheck
 package signalfxexporter
 
 import (