Add new session instrumentation #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8c5de5c to
dd5ec8a
Compare
bidetofevil
approved these changes
Jan 14, 2025
breedx-splk
commented
Jan 15, 2025
breedx-splk
commented
Jan 15, 2025
LikeTheSalad
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will rebase after #717 and is basically a continuation of #571.
Creates a new instrumentation module that is responsible for generation
session.endandsession.startevents, per the semantic conventions. In order to achieve this, theSessionManageris added to theInstallationContext, which (to me) seems reasonable that instrumentations might want to have access to the session.It is currently NOT enabled by default through the agent (opt-in)...but I think we should reconsider this and should make it a default.