Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client metrics for http and ws transports #344

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

WIP: add client metrics for http and ws transports

a3c9ea9
Select commit
Loading
Failed to load commit list.
Draft

Add client metrics for http and ws transports #344

WIP: add client metrics for http and ws transports
a3c9ea9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 21, 2025 in 0s

78.88% (+1.07%) compared to e6fac32

View this Pull Request on Codecov

78.88% (+1.07%) compared to e6fac32

Details

Codecov Report

Attention: Patch coverage is 92.77108% with 12 lines in your changes missing coverage. Please review.

Project coverage is 78.88%. Comparing base (e6fac32) to head (a3c9ea9).

Files with missing lines Patch % Lines
client/internal/wsreceiver.go 82.35% 2 Missing and 1 partial ⚠️
internal/wsmessage.go 62.50% 3 Missing ⚠️
client/internal/httpsender.go 95.00% 2 Missing ⚠️
client/internal/wssender.go 92.00% 1 Missing and 1 partial ⚠️
server/httpconnection.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #344      +/-   ##
==========================================
+ Coverage   77.81%   78.88%   +1.07%     
==========================================
  Files          25       27       +2     
  Lines        2321     2468     +147     
==========================================
+ Hits         1806     1947     +141     
- Misses        408      413       +5     
- Partials      107      108       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.