feat: Add implementation of new AvailableComponents message #340
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #340 +/- ##
==========================================
+ Coverage 77.81% 78.29% +0.47%
==========================================
Files 25 25
Lines 2321 2386 +65
==========================================
+ Hits 1806 1868 +62
- Misses 408 410 +2
- Partials 107 108 +1 ☔ View full report in Codecov by Sentry. |
client/httpclient_test.go
Outdated
| }) | ||
| } else { | ||
| // Verify that no second status report is delivered (polling is too infrequent for this to happen in 3 seconds) | ||
| require.Never(t, func() bool { |
There was a problem hiding this comment.
Does this block the test for 3 seconds? If it does, can we find a way to avoid waiting for so long? We don't want test durations to increase, especially if they are simply idling.
There was a problem hiding this comment.
Reduced all blocking calls to assert/require.Never() to 50ms, including one other test besides the ones I added.
|
Comfortable moving this into Ready for Review - have successfully manually tested this implementation end-to-end with a custom build of the OpAMP Supervisor and OpAMP extension in open-telemetry/opentelemetry-collector-contrib. |
This reverts commit 9e2acf3.
Implements the specification added to opamp-spec in open-telemetry/opamp-spec#201