Disable codecoverage job since it shows wrong data #238
Conversation
Need help for someone to figure out how to fix this. I wasn't able to.
|
Do you know why jobs on main point to your fork of repo on codecov app? Here is the output of latest merge to main run |
|
I believe that is the issue. From what I understand Codecov uses the last successfully uploaded commit as the base commit to compare against when running the checks on PR. The coverage reports on merge to main are getting uploaded here https://app.codecov.io/github/tigrannajaryan/opamp-go/commits instead of here https://app.codecov.io/github/open-telemetry/opamp-go/commits. |
No idea :-( I thought maybe codecov job is using a wrong token (my personal), so I updated it to make sure it is a token from open-telemetry org. Doesn't seem to make a difference. |
|
I manually re-triggered |
|
Re-triggered PR build: #242 |
|
OK, now in codecov's website the report looks correct: https://app.codecov.io/gh/open-telemetry/opamp-go/pull/242 although the comment in the PR posted 2 days ago is wrong. I don't know if there is a way to tell it update the comment and whether this solved the problem completely. |
|
No, doesn't work. I created a new PR and the same problem: #243 |
|
Let's see if we can get some help from codecov team to get this issue sorted out codecov/feedback#123. |
This is from the latest PR #244 @tigrannajaryan I think it is using correct base commit for new PRs created after this successful upload |
OK, it is possible. Let's keep an eye on new PRs. |
|
Looks like new PRs work properly. |
Need help for someone to figure out how to fix this. I wasn't able to.